From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:36336 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727623AbeINTJh (ORCPT ); Fri, 14 Sep 2018 15:09:37 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: rcar-du: Remove packed VYUY support Date: Fri, 14 Sep 2018 16:51:28 +0300 Message-ID: <1759929.4apJ9N5u4E@avalon> In-Reply-To: <20180914132149.26354-1-kieran.bingham+renesas@ideasonboard.com> References: <20180914132149.26354-1-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Friday, 14 September 2018 16:21:49 EEST Kieran Bingham wrote: > The Gen3 VSP used by the DU for display does not support packed the VYUY > pixel format. Gen2 VSP hardware is able to process this format, but it > is not officially supported there either and thus it's output can not be > guaranteed. I think we could guarantee proper operation on Gen2, but as DU + VSP operation isn't enabled in the drivers by default, and as the VYUY format isn't a strategic target, I think we can ignore that. How about updating the commit message as follows ? "The Gen3 VSP used by the DU for display does not support packed the VYUY pixel format. Gen2 VSP hardware is able to process this format, but DU + VSP operation isn't enabled on Gen2, and VYUY isn't a strategic format, so it can be ignored." > Remove the format from the capabilities of the DU driver. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4480243813ec..4576119e7777 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -126,7 +126,6 @@ static const u32 formats_kms[] = { > DRM_FORMAT_ARGB8888, > DRM_FORMAT_XRGB8888, > DRM_FORMAT_UYVY, > - DRM_FORMAT_VYUY, > DRM_FORMAT_YUYV, > DRM_FORMAT_YVYU, > DRM_FORMAT_NV12, > @@ -155,7 +154,6 @@ static const u32 formats_v4l2[] = { > V4L2_PIX_FMT_ABGR32, > V4L2_PIX_FMT_XBGR32, > V4L2_PIX_FMT_UYVY, > - V4L2_PIX_FMT_VYUY, > V4L2_PIX_FMT_YUYV, > V4L2_PIX_FMT_YVYU, > V4L2_PIX_FMT_NV12M, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Remove packed VYUY support Date: Fri, 14 Sep 2018 16:51:28 +0300 Message-ID: <1759929.4apJ9N5u4E@avalon> References: <20180914132149.26354-1-kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4AC0A6E8D9 for ; Fri, 14 Sep 2018 13:51:16 +0000 (UTC) In-Reply-To: <20180914132149.26354-1-kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: David Airlie , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDE0IFNlcHRl bWJlciAyMDE4IDE2OjIxOjQ5IEVFU1QgS2llcmFuIEJpbmdoYW0gd3JvdGU6Cj4gVGhlIEdlbjMg VlNQIHVzZWQgYnkgdGhlIERVIGZvciBkaXNwbGF5IGRvZXMgbm90IHN1cHBvcnQgcGFja2VkIHRo ZSBWWVVZCj4gcGl4ZWwgZm9ybWF0LiBHZW4yIFZTUCBoYXJkd2FyZSBpcyBhYmxlIHRvIHByb2Nl c3MgdGhpcyBmb3JtYXQsIGJ1dCBpdAo+IGlzIG5vdCBvZmZpY2lhbGx5IHN1cHBvcnRlZCB0aGVy ZSBlaXRoZXIgYW5kIHRodXMgaXQncyBvdXRwdXQgY2FuIG5vdCBiZQo+IGd1YXJhbnRlZWQuCgpJ IHRoaW5rIHdlIGNvdWxkIGd1YXJhbnRlZSBwcm9wZXIgb3BlcmF0aW9uIG9uIEdlbjIsIGJ1dCBh cyBEVSArIFZTUCBvcGVyYXRpb24gCmlzbid0IGVuYWJsZWQgaW4gdGhlIGRyaXZlcnMgYnkgZGVm YXVsdCwgYW5kIGFzIHRoZSBWWVVZIGZvcm1hdCBpc24ndCBhIApzdHJhdGVnaWMgdGFyZ2V0LCBJ IHRoaW5rIHdlIGNhbiBpZ25vcmUgdGhhdC4KCkhvdyBhYm91dCB1cGRhdGluZyB0aGUgY29tbWl0 IG1lc3NhZ2UgYXMgZm9sbG93cyA/CgoiVGhlIEdlbjMgVlNQIHVzZWQgYnkgdGhlIERVIGZvciBk aXNwbGF5IGRvZXMgbm90IHN1cHBvcnQgcGFja2VkIHRoZSBWWVVZIApwaXhlbCBmb3JtYXQuIEdl bjIgVlNQIGhhcmR3YXJlIGlzIGFibGUgdG8gcHJvY2VzcyB0aGlzIGZvcm1hdCwgYnV0IERVICsg VlNQIApvcGVyYXRpb24gaXNuJ3QgZW5hYmxlZCBvbiBHZW4yLCBhbmQgVllVWSBpc24ndCBhIHN0 cmF0ZWdpYyBmb3JtYXQsIHNvIGl0IGNhbiAKYmUgaWdub3JlZC4iCgo+IFJlbW92ZSB0aGUgZm9y bWF0IGZyb20gdGhlIGNhcGFiaWxpdGllcyBvZiB0aGUgRFUgZHJpdmVyLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4uYmluZ2hhbStyZW5lc2FzQGlkZWFzb25ib2Fy ZC5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBp ZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9k dV92c3AuYyB8IDIgLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMKPiBiL2RyaXZl cnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMgaW5kZXggNDQ4MDI0MzgxM2VjLi40NTc2 MTE5ZTc3NzcKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X3ZzcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYwo+IEBA IC0xMjYsNyArMTI2LDYgQEAgc3RhdGljIGNvbnN0IHUzMiBmb3JtYXRzX2ttc1tdID0gewo+ICAJ RFJNX0ZPUk1BVF9BUkdCODg4OCwKPiAgCURSTV9GT1JNQVRfWFJHQjg4ODgsCj4gIAlEUk1fRk9S TUFUX1VZVlksCj4gLQlEUk1fRk9STUFUX1ZZVVksCj4gIAlEUk1fRk9STUFUX1lVWVYsCj4gIAlE Uk1fRk9STUFUX1lWWVUsCj4gIAlEUk1fRk9STUFUX05WMTIsCj4gQEAgLTE1NSw3ICsxNTQsNiBA QCBzdGF0aWMgY29uc3QgdTMyIGZvcm1hdHNfdjRsMltdID0gewo+ICAJVjRMMl9QSVhfRk1UX0FC R1IzMiwKPiAgCVY0TDJfUElYX0ZNVF9YQkdSMzIsCj4gIAlWNEwyX1BJWF9GTVRfVVlWWSwKPiAt CVY0TDJfUElYX0ZNVF9WWVVZLAo+ICAJVjRMMl9QSVhfRk1UX1lVWVYsCj4gIAlWNEwyX1BJWF9G TVRfWVZZVSwKPiAgCVY0TDJfUElYX0ZNVF9OVjEyTSwKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK