From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Niranjan H Y <niranjan.hy@ti.com>,
krzk+dt@kernel.org, conor+dt@kernel.org,
andriy.shevchenko@linux.intel.com, tiwai@suse.de,
alsa-devel@alsa-project.org, baojun.xu@ti.com,
shenghao-ding@ti.com, liam.r.girdwood@intel.com,
lgirdwood@gmail.com, robh@kernel.org,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
navada@ti.com, v-hampiholi@ti.com
Subject: Re: [PATCH v3 4/4] dt-bindings: sound: device support list for pcm6240
Date: Sat, 28 Jun 2025 13:51:50 +0200 [thread overview]
Message-ID: <175f26a6-d450-4397-8460-87d9162b563b@kernel.org> (raw)
In-Reply-To: <aF57GqVuSqmF9W6H@finisterre.sirena.org.uk>
On 27/06/2025 13:06, Mark Brown wrote:
> On Fri, Jun 27, 2025 at 09:43:54AM +0200, Krzysztof Kozlowski wrote:
>> On Thu, Jun 26, 2025 at 11:43:33PM +0530, Niranjan H Y wrote:
>
>>> Removed taa* and tad* device from the support list
>>> as these devices are supported by tac5x1x codec driver
>
>> No, why? Hardware does not change.
>
> So long as the bindings are compatible it's not a problem, this does
> happen sometimes when people realise that a device needs more specific
> support and it's more managable to split out from a common binding. The
> commit log should have the analysis of this though.
Yeah and then it should be one commit moving - not removing -
compatibles to a new binding, with that analysis or explanation.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-06-28 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 18:13 [PATCH v3 0/4] ASoc: tac5x1x: mixer-test report Niranjan H Y
2025-06-26 18:13 ` [PATCH v3 1/4] ASoc: tac5x1x: add codec driver tac5x1x family Niranjan H Y
2025-06-27 7:49 ` Krzysztof Kozlowski
2025-06-27 10:48 ` kernel test robot
2025-06-27 11:04 ` Mark Brown
2025-06-26 18:13 ` [PATCH v3 2/4] dt-bindings: sound: bindings for tac5x1x family of codecs Niranjan H Y
2025-06-26 19:39 ` Rob Herring (Arm)
2025-06-27 7:48 ` Krzysztof Kozlowski
2025-06-26 18:13 ` [PATCH v3 3/4] Asoc: pcm6240: remove support for taac5x1x family Niranjan H Y
2025-06-26 18:13 ` [PATCH v3 4/4] dt-bindings: sound: device support list for pcm6240 Niranjan H Y
2025-06-27 7:43 ` Krzysztof Kozlowski
2025-06-27 11:06 ` Mark Brown
2025-06-28 11:51 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175f26a6-d450-4397-8460-87d9162b563b@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=niranjan.hy@ti.com \
--cc=robh@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=v-hampiholi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.