From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH V2 13/17] ARM: exynos: cpuidle: Move clock setup to pm.c Date: Fri, 04 Apr 2014 17:35:14 +0200 Message-ID: <1760778.bkYYS0bViq@amdc1032> References: <1396618989-2897-1-git-send-email-daniel.lezcano@linaro.org> <1396618989-2897-14-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:22163 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753058AbaDDPfn (ORCPT ); Fri, 4 Apr 2014 11:35:43 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3I00711JBG5T40@mailout4.samsung.com> for linux-samsung-soc@vger.kernel.org; Sat, 05 Apr 2014 00:35:40 +0900 (KST) In-reply-to: <1396618989-2897-14-git-send-email-daniel.lezcano@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Daniel Lezcano Cc: kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, t.figa@samsung.com, linaro-kernel@lists.linaro.org, rjw@rjwysocki.net On Friday, April 04, 2014 03:43:05 PM Daniel Lezcano wrote: > One more step is moving the clock ratio setting at idle time in pm.c > > The macro names have been changed to be consistent with the other macros > name in the file. > > Note, the clock divider was working only when cpuidle was enabled because it > was in its init routine. With this change, the clock divider is set in the pm's > init routine, so it will also operate when the cpuidle driver is not set, which > is good. > > Signed-off-by: Daniel Lezcano > Reviewed-by: Viresh Kumar There was the earlier patch which was moving this code to clock driver however it fell through cracks. Either way is fine with me so.. Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) Date: Fri, 04 Apr 2014 17:35:14 +0200 Subject: [PATCH V2 13/17] ARM: exynos: cpuidle: Move clock setup to pm.c In-Reply-To: <1396618989-2897-14-git-send-email-daniel.lezcano@linaro.org> References: <1396618989-2897-1-git-send-email-daniel.lezcano@linaro.org> <1396618989-2897-14-git-send-email-daniel.lezcano@linaro.org> Message-ID: <1760778.bkYYS0bViq@amdc1032> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday, April 04, 2014 03:43:05 PM Daniel Lezcano wrote: > One more step is moving the clock ratio setting at idle time in pm.c > > The macro names have been changed to be consistent with the other macros > name in the file. > > Note, the clock divider was working only when cpuidle was enabled because it > was in its init routine. With this change, the clock divider is set in the pm's > init routine, so it will also operate when the cpuidle driver is not set, which > is good. > > Signed-off-by: Daniel Lezcano > Reviewed-by: Viresh Kumar There was the earlier patch which was moving this code to clock driver however it fell through cracks. Either way is fine with me so.. Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics