Re: [Xenomai-core] [RFC][PATCH 4/4] shorten overrun loops of periodic timers

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

Jan Kiszka wrote:
 > A simple patch, just like suggested by Gilles, to avoid looping over
 > periodic xntimer handlers in case of overruns.
 > 
 > It saves the current TSC on loop entry and uses this value later when
 > forwarding the timer. Is is the overhead of re-reading the TSC on all
 > archs negligible and should we rather go that way?

 >(...)
 > -				xntimerh_date(&timer->aplink) +=
 > -				    nkpod->htimer.interval;
 > +				while ((xntimerh_date(&timer->aplink) +=
 > +				        nkpod->htimer.interval) < now);

I think you are patching the wrong addition, the one you are interested
in is most probably the one at the bottom of xntimer_do_tick_aperiodic.

-- 


					    Gilles Chanteperdrix.