From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED6333859C; Wed, 12 Nov 2025 14:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762959037; cv=none; b=AhdGxxUCBpTcw2wChv57KHSfw4zZCe/iOfP7+0mPxQM9IuRxCET+L4XnrykcoFF0Mq2TbUyNOKvv2485TBHJfv3VjjQQwhfbTKC6Cya8PxrLKHavVe/0RhcbG4vJ5Q4clkIn0iW7d+exzJ7Sg24lUYoDlUESCoSTiF5XBSbUSPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762959037; c=relaxed/simple; bh=fDyqUYG96cnQY+L9W/+s4ilvkJlQdMXHRO6AeDHlCzI=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=Yms1R2HM0w1WAc2A1mAinG3VBE+IL/wWShUr4SjVRfZKEZIcOL+GRb/b+JiHxrk71lHLKpY1D7bjzZICP1VKTeVFsVaQks/B1stHYQArOzFgX89084ulE+Jr/JJPLuGjqL4gg6TWOALBI2bS2qFoGVM5bcFvLq6V4/q4kC/qUvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=enBY7x6Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="enBY7x6Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C317FC4CEF7; Wed, 12 Nov 2025 14:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762959036; bh=fDyqUYG96cnQY+L9W/+s4ilvkJlQdMXHRO6AeDHlCzI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=enBY7x6YOWv87kpNak4NrFB8JtZ3UVXQuLOeCAaj6KUbV7onIs9gxe3f9AeakO/UD P9eC6n1V+zD9y14jPBKQXNdiwFWCkIL/ENmV5k9VIeu7Q+Nq5Te9yLdQLMd2eAlUeg oKk8bFYOfMrgnmuXhvcvdgjgoF+jv7G9Npc5uNdflqeXzjDoIFBF0ao7BlTFrDIBER WPxW+kQ0/k5jeCxf4L1ZlrSQyoyW+ZUsbthCnokc6bNsq/ZCLUjXr6rvA/asAwvQ3B dN3rWLyryTt87mMkUEJ5I8rcVupgRBgwiglVwJqgR9GZ4BNh0keKckGoqJaKn+y9Tw PPXSl/G8Y5KVg== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id AE16739EFA4C; Wed, 12 Nov 2025 14:50:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v1] ipv4: route: Prevent rt_bind_exception() from rebinding stale fnhe From: patchwork-bot+netdevbpf@kernel.org Message-Id: <176295900651.38875.8173375178181875394.git-patchwork-notify@kernel.org> Date: Wed, 12 Nov 2025 14:50:06 +0000 References: <20251111064328.24440-1-nashuiliang@gmail.com> In-Reply-To: <20251111064328.24440-1-nashuiliang@gmail.com> To: Chuang Wang Cc: stable@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 11 Nov 2025 14:43:24 +0800 you wrote: > The sit driver's packet transmission path calls: sit_tunnel_xmit() -> > update_or_create_fnhe(), which lead to fnhe_remove_oldest() being called > to delete entries exceeding FNHE_RECLAIM_DEPTH+random. > > The race window is between fnhe_remove_oldest() selecting fnheX for > deletion and the subsequent kfree_rcu(). During this time, the > concurrent path's __mkroute_output() -> find_exception() can fetch the > soon-to-be-deleted fnheX, and rt_bind_exception() then binds it with a > new dst using a dst_hold(). When the original fnheX is freed via RCU, > the dst reference remains permanently leaked. > > [...] Here is the summary with links: - [net,v1] ipv4: route: Prevent rt_bind_exception() from rebinding stale fnhe https://git.kernel.org/netdev/net/c/ac1499fcd40f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html