From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: pali.rohar@gmail.com, Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include
Date: Tue, 12 Mar 2019 07:26:06 -0400 [thread overview]
Message-ID: <17631.1552389966@turing-police> (raw)
Building with W=1 complains:
CC [M] drivers/platform/x86/dell-rbtn.o
drivers/platform/x86/dell-rbtn.c:345:5: warning: no previous prototype for 'dell_rbtn_notifier_register' [-Wmissing-prototypes]
345 | int dell_rbtn_notifier_register(struct notifier_block *nb)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/dell-rbtn.c:371:5: warning: no previous prototype for 'dell_rbtn_notifier_unregister' [-Wmissing-prototypes]
371 | int dell_rbtn_notifier_unregister(struct notifier_block *nb)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The real problem is a missing include. Add it to keep dell-rbtn.c and .h in sync
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
index f3afe778001e..d50ca96d99f0 100644
--- a/drivers/platform/x86/dell-rbtn.c
+++ b/drivers/platform/x86/dell-rbtn.c
@@ -17,6 +17,7 @@
#include <linux/acpi.h>
#include <linux/rfkill.h>
#include <linux/input.h>
+#include "dell-rbtn.h"
enum rbtn_type {
RBTN_UNKNOWN,
next reply other threads:[~2019-03-12 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 11:26 Valdis Klētnieks [this message]
2019-03-12 22:46 ` [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include Pali Rohár
2019-03-12 22:53 ` valdis.kletnieks
2019-04-05 14:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17631.1552389966@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.