From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/7] mem: use proper prefix
Date: Thu, 01 Nov 2018 15:50:59 +0100 [thread overview]
Message-ID: <1764123.29vNcfR2yM@xps> (raw)
In-Reply-To: <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com>
01/11/2018 11:08, Burakov, Anatoly:
> On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
> > Current name rte_eal_check_dma_mask does not follow the naming
> > used in the rest of the file.
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
>
> I don't think this belongs in the _mem_ namespace. It is usually used
> for things to do with memory, while the DMA mask IMO sits firmly in the
> domain of EAL, specifically bus subsystem.
It is a memory allocation check, isn't it?
I think rte_mem_ prefix is more meaningful.
Anyway, we should avoid rte_eal which is too vague.
For device management, we use rte_bus, rte_dev, etc.
> However, i don't have strong feelings one way or the other, so if you do
> decide to go forward with this naming...
next prev parent reply other threads:[~2018-11-01 14:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 17:29 [PATCH 0/7] fix DMA mask check Alejandro Lucero
2018-10-31 17:29 ` [PATCH 1/7] mem: fix call to " Alejandro Lucero
2018-11-01 10:11 ` Burakov, Anatoly
2018-10-31 17:29 ` [PATCH 2/7] mem: use proper prefix Alejandro Lucero
2018-11-01 10:08 ` Burakov, Anatoly
2018-11-01 10:40 ` Alejandro Lucero
2018-11-01 14:50 ` Thomas Monjalon [this message]
2018-11-01 15:03 ` Burakov, Anatoly
2018-11-01 16:18 ` Alejandro Lucero
2018-10-31 17:29 ` [PATCH 3/7] mem: add function for setting DMA mask Alejandro Lucero
2018-11-01 10:11 ` Burakov, Anatoly
2018-11-01 10:48 ` Alejandro Lucero
2018-11-01 10:57 ` Burakov, Anatoly
2018-11-01 11:30 ` Alejandro Lucero
2018-11-01 14:32 ` Alejandro Lucero
2018-10-31 17:29 ` [PATCH 4/7] bus/pci: avoid call to DMA mask check Alejandro Lucero
2018-11-01 10:12 ` Burakov, Anatoly
2018-10-31 17:29 ` [PATCH 5/7] mem: modify error message for " Alejandro Lucero
2018-11-01 10:29 ` Burakov, Anatoly
2018-11-01 11:03 ` Alejandro Lucero
2018-11-01 11:12 ` Burakov, Anatoly
2018-11-01 11:32 ` Alejandro Lucero
2018-10-31 17:29 ` [PATCH 6/7] mem: add safe and unsafe versions for checking DMA mask Alejandro Lucero
2018-11-01 10:38 ` Burakov, Anatoly
2018-11-01 13:34 ` Alejandro Lucero
2018-10-31 17:29 ` [PATCH 7/7] eal/mem: use DMA mask check for legacy memory Alejandro Lucero
2018-11-01 10:40 ` Burakov, Anatoly
2018-11-01 13:39 ` Alejandro Lucero
2018-11-01 14:28 ` Burakov, Anatoly
2018-11-01 14:32 ` Alejandro Lucero
2018-10-31 17:47 ` [PATCH 0/7] fix DMA mask check Alejandro Lucero
2018-11-02 5:52 ` Hyong Youb Kim
2018-11-01 10:13 ` Mattias Rönnblom
2018-11-01 17:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1764123.29vNcfR2yM@xps \
--to=thomas@monjalon.net \
--cc=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.