From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43336)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bot96-0004ol-Fv
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 10:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bot93-0007YY-5U
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 10:14:08 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:56486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bot92-0007YH-SD
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 10:14:05 -0400
Date: Tue, 27 Sep 2016 10:14:00 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1764179128.3091209.1474985640517.JavaMail.zimbra@redhat.com>
In-Reply-To: <87lgydii9w.fsf@dusky.pond.sub.org>
References: <cover.1474331683.git.alistair.francis@xilinx.com>
	<87h998nvf6.fsf@dusky.pond.sub.org>
	<6280ba63-cbe9-c2d3-ba8f-7de1369f059e@redhat.com>
	<87vaxojgqw.fsf@dusky.pond.sub.org>
	<CAFEAcA_1iw4z3U6kwMBvsN7HHbtj=T-mJ4=aQ7yquYQ5pvzpOQ@mail.gmail.com>
	<87ponvxcit.fsf@dusky.pond.sub.org>
	<7046636c-a89b-2991-083f-bf73bb29f070@redhat.com>
	<87lgydii9w.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, Christopher Covington <cov@codeaurora.org>, Alistair Francis <alistair.francis@xilinx.com>

It does whatever cpu_physical_memory_write_rom (and hence
cpu_memory_rw_debug, which has more callers) do.

> What happens when you try to monkey-patch and address that isn't
> connected to anything?

/dev/null

> What happens when you try to monkey-patch some device's ROM?

Overwritten.

> Memory-mapped I/O?

Ignored.

> What happens when you monkey-patch persistent memory, such as pflash
> backed by a block backend?

Overwritten (but not flushed).

> What happens if the address range crosses device boundaries?

Writes over each area separately.

> >> If we decide to use this argument for the present interface design, I
> >> want it recorded in the code and commit messages.
> 
> Fair request, don't you think?

Yes, of course.

Paolo