From: David Woodhouse <dwmw2@infradead.org>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com,
alan@lxorguk.ukuu.org.uk
Subject: Re: [patch] 2.4.11-pre4 EXPORT_SYMBOLS
Date: Fri, 05 Oct 2001 08:01:13 +0100 [thread overview]
Message-ID: <17653.1002265273@redhat.com> (raw)
In-Reply-To: <3982.1002260102@kao2.melbourne.sgi.com>
In-Reply-To: <3982.1002260102@kao2.melbourne.sgi.com>
kaos@ocs.com.au said:
> Some developers are forgetting to update export-objs in the Makefile,
> the bug is silent until somebody compiles with modversions. This
> patch catches missing Makefile changes.
Thanks. Patch below, which fixes this and also hides a couple of
ARM-specific modules so you can't attempt to build them for other targets.
Index: drivers/mtd/chips/Makefile
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/chips/Makefile,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- drivers/mtd/chips/Makefile 2001/09/02 18:57:01 1.6
+++ drivers/mtd/chips/Makefile 2001/10/05 06:53:51 1.7
@@ -1,11 +1,11 @@
#
# linux/drivers/chips/Makefile
#
-# $Id: Makefile,v 1.6 2001/09/02 18:57:01 dwmw2 Exp $
+# $Id: Makefile,v 1.7 2001/10/05 06:53:51 dwmw2 Exp $
O_TARGET := chipslink.o
-export-objs := chipreg.o
+export-objs := chipreg.o gen_probe.o
# *** BIG UGLY NOTE ***
#
Index: drivers/mtd/Config.in
===================================================================
RCS file: /home/cvs/mtd/drivers/mtd/Config.in,v
retrieving revision 1.70
retrieving revision 1.71
diff -u -r1.70 -r1.71
--- drivers/mtd/Config.in 2001/08/11 16:13:38 1.70
+++ drivers/mtd/Config.in 2001/10/03 11:38:38 1.71
@@ -1,5 +1,5 @@
-# $Id: Config.in,v 1.70 2001/08/11 16:13:38 dwmw2 Exp $
+# $Id: Config.in,v 1.71 2001/10/03 11:38:38 dwmw2 Exp $
mainmenu_option next_comment
comment 'Memory Technology Devices (MTD)'
@@ -13,8 +13,10 @@
fi
dep_tristate ' MTD partitioning support' CONFIG_MTD_PARTITIONS $CONFIG_MTD
dep_tristate ' RedBoot partition table parsing' CONFIG_MTD_REDBOOT_PARTS $CONFIG_MTD_PARTITIONS
+if [ "$CONFIG_ARM" = "y" ]; then
dep_tristate ' Compaq bootldr partition table parsing' CONFIG_MTD_BOOTLDR_PARTS $CONFIG_MTD_PARTITIONS
dep_tristate ' ARM Firmware Suite partition parsing' CONFIG_MTD_AFS_PARTS $CONFIG_MTD_PARTITIONS
+fi
comment 'User Modules And Translation Layers'
dep_tristate ' Direct char device access to MTD devices' CONFIG_MTD_CHAR $CONFIG_MTD
--
dwmw2
prev parent reply other threads:[~2001-10-05 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-05 5:35 [patch] 2.4.11-pre4 EXPORT_SYMBOLS Keith Owens
2001-10-05 7:01 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17653.1002265273@redhat.com \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.