From: patchwork-bot+netdevbpf@kernel.org
To: Jens Axboe <axboe@kernel.dk>
Cc: netdev@vger.kernel.org, io-uring@vger.kernel.org,
kuba@kernel.org, willemb@google.com, kuniyu@google.com,
ju.orth@gmail.com
Subject: Re: [PATCH v2] af_unix: don't post cmsg for SO_INQ unless explicitly asked for
Date: Sun, 28 Dec 2025 15:32:04 +0000 [thread overview]
Message-ID: <176693592455.2340895.15053745260316730629.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <07adc0c2-2c3b-4d08-8af1-1c466a40b6a8@kernel.dk>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Thu, 18 Dec 2025 15:21:28 -0700 you wrote:
> A previous commit added SO_INQ support for AF_UNIX (SOCK_STREAM), but it
> posts a SCM_INQ cmsg even if just msg->msg_get_inq is set. This is
> incorrect, as ->msg_get_inq is just the caller asking for the remainder
> to be passed back in msg->msg_inq, it has nothing to do with cmsg. The
> original commit states that this is done to make sockets
> io_uring-friendly", but it's actually incorrect as io_uring doesn't use
> cmsg headers internally at all, and it's actively wrong as this means
> that cmsg's are always posted if someone does recvmsg via io_uring.
>
> [...]
Here is the summary with links:
- [v2] af_unix: don't post cmsg for SO_INQ unless explicitly asked for
https://git.kernel.org/netdev/net/c/4d1442979e4a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-12-28 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 22:21 [PATCH v2] af_unix: don't post cmsg for SO_INQ unless explicitly asked for Jens Axboe
2025-12-19 19:02 ` Willem de Bruijn
2025-12-19 19:55 ` Jens Axboe
2025-12-19 20:08 ` Willem de Bruijn
2025-12-19 20:24 ` Jens Axboe
2025-12-19 22:03 ` Willem de Bruijn
2025-12-23 17:27 ` Jens Axboe
2025-12-28 15:02 ` Paolo Abeni
2025-12-28 15:45 ` Jens Axboe
2025-12-28 15:32 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176693592455.2340895.15053745260316730629.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=ju.orth@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.