Re: [PATCH 1/2] serial: sh-sci: Fix cast warning

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Jingoo,

Thank you for the patch.

On Tuesday 04 February 2014 15:55:41 Jingoo Han wrote:
> Fix the following compile warning about cast to pointer from
> integer of different size.
> 
> drivers/tty/serial/sh-sci.c:2021:19: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cast]
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/tty/serial/sh-sci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index be33d2b..61729d4 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -2018,7 +2018,7 @@ static int sci_remap_port(struct uart_port *port)
>  		 * need to do any remapping, just cast the cookie
>  		 * directly.
>  		 */
> -		port->membase = (void __iomem *)port->mapbase;
> +		port->membase = (void __iomem *)(unsigned long)port->mapbase;

What about casting to uintptr_t instead of unsigned long ?

>  	}
> 
>  	return 0;

-- 
Regards,

Laurent Pinchart