From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A8A316D308; Tue, 28 May 2024 11:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716897144; cv=none; b=H6Xa6eOxzg2nWY8E5ZwJki6/MppbybFGqCOtJD+lTwa8nCrH9Rk+2pLibYEvWHrhhSDwXyXR2yCy/iLi1C4L1bVEKkCRQPCoBHuEGGTrDAyXO5zHJC7AyZhly9IOWupDW7D/vyOoZsX8foUNlWqJj3m3Rm1iZRpw3Ek01KY+04w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716897144; c=relaxed/simple; bh=7nJOrIbNRBb2wO3PiDfHyphKLt0y6wyGs2WF4qB8lcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=osf+78gPHYmZObseWPiVzPt1O3skJtRtLa34Osz+SDgAThtVsdpCGzFJX+R4om2RHlBlvMwFtQV1BZO1CZLDEPZeDw6e5TD8U3J7Jumn+MxWRdYCxHkxL36IPxEbrofQkg1aI+//Vynj1SrNvMHFHKsQI8dh18xnJr4LePH01Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBvNH-0003GJ-RU; Tue, 28 May 2024 13:52:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dmitry Yashin , Linus Walleij Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 13:52:14 +0200 Message-ID: <1770701.X513TT2pbd@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <20240515121634.23945-2-dmt.yashin@gmail.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Hi Linus, Am Dienstag, 28. Mai 2024, 13:29:12 CEST schrieb Linus Walleij: > On Wed, May 15, 2024 at 2:17=E2=80=AFPM Dmitry Yashin wrote: >=20 > > Some of the rk3308 iomux routes in rk3308_mux_route_data belong to > > the rk3308b SoC. Remove them and correct i2c3 routes. > > > > Fixes: 7825aeb7b208 ("pinctrl: rockchip: add rk3308 SoC support") > > Signed-off-by: Dmitry Yashin >=20 > While you guys are thinking about the RK3308B support, is this fix > something I can just apply? I'd think so. I've detailed stuff in my Review mail I just sent. Both the soc itself and also the affected pin functions are niche enough that this should not cause breakage. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6292EC25B7C for ; Tue, 28 May 2024 11:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XKSGmxmMyDMUHRAWv6PkTNByrC6rYRSX/krNVULhseM=; b=kCZ50xna17ZqQO yhLaOA4ZfiB2hu9apIo41kf8PNUhSvjrDQfA2bQHU3Nwto3Je7/CwKkQe/pYP+6He2mIvodf5qkOP OdZ8OQLj5I2qi+QP1IJaLCMA7DfRuBHkveQ5y3gIAahqZD2byWDD5mh1rZponNlfcCz11e1BZvvTL GjBzLViARDcQYa0BvgYqHDIK2B5AIsttyPoGj8qtBWj4XpKBvR1VL9ZaAcUvv6fKhZXIHsPENleEd dhbrnMoYxe9xSwJRlmcr4O7si4aSCNFiOmh3D83D7nr/17zOS8sZ258hxL22t/WqS5Rb5L+DRhfQX krbt1Ys0M34eyOc3ymuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvNQ-00000000SUF-2UgO; Tue, 28 May 2024 11:52:24 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvNN-00000000SSO-2DOA; Tue, 28 May 2024 11:52:22 +0000 Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBvNH-0003GJ-RU; Tue, 28 May 2024 13:52:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dmitry Yashin , Linus Walleij Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 13:52:14 +0200 Message-ID: <1770701.X513TT2pbd@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <20240515121634.23945-2-dmt.yashin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_045221_587365_4FD4C7AF X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgTGludXMsCgpBbSBEaWVuc3RhZywgMjguIE1haSAyMDI0LCAxMzoyOToxMiBDRVNUIHNjaHJp ZWIgTGludXMgV2FsbGVpajoKPiBPbiBXZWQsIE1heSAxNSwgMjAyNCBhdCAyOjE34oCvUE0gRG1p dHJ5IFlhc2hpbiA8ZG10Lnlhc2hpbkBnbWFpbC5jb20+IHdyb3RlOgo+IAo+ID4gU29tZSBvZiB0 aGUgcmszMzA4IGlvbXV4IHJvdXRlcyBpbiByazMzMDhfbXV4X3JvdXRlX2RhdGEgYmVsb25nIHRv Cj4gPiB0aGUgcmszMzA4YiBTb0MuIFJlbW92ZSB0aGVtIGFuZCBjb3JyZWN0IGkyYzMgcm91dGVz Lgo+ID4KPiA+IEZpeGVzOiA3ODI1YWViN2IyMDggKCJwaW5jdHJsOiByb2NrY2hpcDogYWRkIHJr MzMwOCBTb0Mgc3VwcG9ydCIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgWWFzaGluIDxkbXQu eWFzaGluQGdtYWlsLmNvbT4KPiAKPiBXaGlsZSB5b3UgZ3V5cyBhcmUgdGhpbmtpbmcgYWJvdXQg dGhlIFJLMzMwOEIgc3VwcG9ydCwgaXMgdGhpcyBmaXgKPiBzb21ldGhpbmcgSSBjYW4ganVzdCBh cHBseT8KCkknZCB0aGluayBzby4gSSd2ZSBkZXRhaWxlZCBzdHVmZiBpbiBteSBSZXZpZXcgbWFp bCBJIGp1c3Qgc2VudC4KQm90aCB0aGUgc29jIGl0c2VsZiBhbmQgYWxzbyB0aGUgYWZmZWN0ZWQg cGluIGZ1bmN0aW9ucyBhcmUgbmljaGUKZW5vdWdoIHRoYXQgdGhpcyBzaG91bGQgbm90IGNhdXNl IGJyZWFrYWdlLgoKCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8B94C25B78 for ; Tue, 28 May 2024 11:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=10F2SeCA1/aDyR1lz/1kr+hE039UIQ7KoMFRSde0znI=; b=YfpIqkYk8qiKgt jvvcNJvkBQ+dR66u1UdMwkeUbm4y5LwShBFatnowC4j8pntl3VzrN6UEtnyjFlTZXo1ubZINTcMeh oNVqol2VrLTJRjhnCN/l1So924m+PffiPbG5lJhpTm1P7L5oLQOCmuDUcfn8uMy8+5G/QX2a7QK9m kMTHOplGv/Y41s6QfsEo1SFJ54+lTG8emWf0mInJYFT/MBIK1ID+qVQz82g+q6Ydf8PZPQ4r7bNpi 6pR7WcF9ei/BGNwU3ZLVEREbfGIP2wVw0vMZcvtXoyghsM2Y7WwLZyQAYl87Erz/sFjj+fy96P/af r9XOIiWLZpPn/Xgo4A8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvNP-00000000STS-3eGt; Tue, 28 May 2024 11:52:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvNN-00000000SSO-2DOA; Tue, 28 May 2024 11:52:22 +0000 Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBvNH-0003GJ-RU; Tue, 28 May 2024 13:52:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dmitry Yashin , Linus Walleij Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 13:52:14 +0200 Message-ID: <1770701.X513TT2pbd@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <20240515121634.23945-2-dmt.yashin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_045221_587365_4FD4C7AF X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGludXMsCgpBbSBEaWVuc3RhZywgMjguIE1haSAyMDI0LCAxMzoyOToxMiBDRVNUIHNjaHJp ZWIgTGludXMgV2FsbGVpajoKPiBPbiBXZWQsIE1heSAxNSwgMjAyNCBhdCAyOjE34oCvUE0gRG1p dHJ5IFlhc2hpbiA8ZG10Lnlhc2hpbkBnbWFpbC5jb20+IHdyb3RlOgo+IAo+ID4gU29tZSBvZiB0 aGUgcmszMzA4IGlvbXV4IHJvdXRlcyBpbiByazMzMDhfbXV4X3JvdXRlX2RhdGEgYmVsb25nIHRv Cj4gPiB0aGUgcmszMzA4YiBTb0MuIFJlbW92ZSB0aGVtIGFuZCBjb3JyZWN0IGkyYzMgcm91dGVz Lgo+ID4KPiA+IEZpeGVzOiA3ODI1YWViN2IyMDggKCJwaW5jdHJsOiByb2NrY2hpcDogYWRkIHJr MzMwOCBTb0Mgc3VwcG9ydCIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgWWFzaGluIDxkbXQu eWFzaGluQGdtYWlsLmNvbT4KPiAKPiBXaGlsZSB5b3UgZ3V5cyBhcmUgdGhpbmtpbmcgYWJvdXQg dGhlIFJLMzMwOEIgc3VwcG9ydCwgaXMgdGhpcyBmaXgKPiBzb21ldGhpbmcgSSBjYW4ganVzdCBh cHBseT8KCkknZCB0aGluayBzby4gSSd2ZSBkZXRhaWxlZCBzdHVmZiBpbiBteSBSZXZpZXcgbWFp bCBJIGp1c3Qgc2VudC4KQm90aCB0aGUgc29jIGl0c2VsZiBhbmQgYWxzbyB0aGUgYWZmZWN0ZWQg cGluIGZ1bmN0aW9ucyBhcmUgbmljaGUKZW5vdWdoIHRoYXQgdGhpcyBzaG91bGQgbm90IGNhdXNl IGJyZWFrYWdlLgoKCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK