From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] ARM: EXYNOS: remove CONFIG_MACH_EXYNOS[4,5]_DT config options Date: Mon, 23 Sep 2013 14:34:54 +0200 Message-ID: <1773131.OsQeaPpRlR@amdc1227> References: <3809234.0NkWBIjRC9@amdc1032> <2298139.uMOnikAvfC@amdc1227> <1732670.G7NvXXJtxF@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:60916 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892Ab3IWMfH (ORCPT ); Mon, 23 Sep 2013 08:35:07 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00FXNW8TUD10@mailout1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 23 Sep 2013 13:35:05 +0100 (BST) In-reply-to: <1732670.G7NvXXJtxF@amdc1032> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com, Sylwester Nawrocki On Monday 23 of September 2013 12:23:51 Bartlomiej Zolnierkiewicz wrote: > Hi Tomek, > > On Tuesday, September 17, 2013 12:45:21 PM Tomasz Figa wrote: > > Hi Bart, [snip] > > > + select ARM_AMBA > > > + select CLKSRC_OF > > > + select CLKSRC_SAMSUNG_PWM if CPU_EXYNOS4210 > > > + select CPU_EXYNOS4210 > > > > The line above shows the brokenness of current layout of Exynos Kconfig > > options. You need to select some SoC in SAMSUNG EXYNOS4, because > > otherwise the build will fail if user doesn't select at least one of > > Exynos4 SoCs. > > > > Instead, I would hide the ARCH_EXYNOS4 and ARCH_EXYNOS4 options and > > select them from entries of particular SoCs, i.e. ARCH_EXYNOS4 would > > be selected by CPU_EXYNOS4210, SOC_EXYNOS4212 and SOC_EXYNOS4412, > > ARCH_EXYNOS5 by SOC_EXYNOS5250 and SOC_EXYNOS5420 and so on. > > This is a good idea but I think that it is better to address it later in > an incremental patch (which I will also do unless someone beats me to > it). OK, sounds good. I take your word for it. ;) Acked-by: Tomasz Figa Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Mon, 23 Sep 2013 14:34:54 +0200 Subject: [PATCH] ARM: EXYNOS: remove CONFIG_MACH_EXYNOS[4,5]_DT config options In-Reply-To: <1732670.G7NvXXJtxF@amdc1032> References: <3809234.0NkWBIjRC9@amdc1032> <2298139.uMOnikAvfC@amdc1227> <1732670.G7NvXXJtxF@amdc1032> Message-ID: <1773131.OsQeaPpRlR@amdc1227> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 23 of September 2013 12:23:51 Bartlomiej Zolnierkiewicz wrote: > Hi Tomek, > > On Tuesday, September 17, 2013 12:45:21 PM Tomasz Figa wrote: > > Hi Bart, [snip] > > > + select ARM_AMBA > > > + select CLKSRC_OF > > > + select CLKSRC_SAMSUNG_PWM if CPU_EXYNOS4210 > > > + select CPU_EXYNOS4210 > > > > The line above shows the brokenness of current layout of Exynos Kconfig > > options. You need to select some SoC in SAMSUNG EXYNOS4, because > > otherwise the build will fail if user doesn't select at least one of > > Exynos4 SoCs. > > > > Instead, I would hide the ARCH_EXYNOS4 and ARCH_EXYNOS4 options and > > select them from entries of particular SoCs, i.e. ARCH_EXYNOS4 would > > be selected by CPU_EXYNOS4210, SOC_EXYNOS4212 and SOC_EXYNOS4412, > > ARCH_EXYNOS5 by SOC_EXYNOS5250 and SOC_EXYNOS5420 and so on. > > This is a good idea but I think that it is better to address it later in > an incremental patch (which I will also do unless someone beats me to > it). OK, sounds good. I take your word for it. ;) Acked-by: Tomasz Figa Best regards, Tomasz