From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [RFC/PATCH] Stop Apple i2s DMA gracefully Date: Wed, 1 Nov 2006 12:05:40 +1100 Message-ID: <17735.62180.65780.364256@cargo.ozlabs.ibm.com> References: <17732.11228.441627.300383@cargo.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 8C4D42C0 for ; Wed, 1 Nov 2006 02:21:01 +0100 (MET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Takashi Iwai Cc: Johannes Berg , alsa-devel@alsa-project.org, benjamin@sipsolutions.net List-Id: alsa-devel@alsa-project.org Takashi Iwai writes: > We need no irqsave/irqrestore but here since the function is supposed > to be called always in schedulable situation. spin_lock_irq() should > be enough. OK. > Any reason to put extra inline here? It's no time-critical funciton, > so let compiler do optimization. Sure. > BTW, shoud this go to 2.6.19 although the fix isn't so trivial, or > could wait for the next? I don't have a strong feeling either way. It is a bug fix, but for a bug which doesn't seem to have affected many people (although perhaps people were avoiding using capture because it didn't work properly), but it's not a bug which can lead to any crash or vulnerability as far as I can see. Paul. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642