All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Wade <danjwade95@gmail.com>
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com,
	ameryhung@gmail.com, ast@kernel.org
Subject: Re: [PATCH bpf v4 0/2] bpf: Fix unsound scalar forking for BPF_OR
Date: Sat, 21 Mar 2026 20:20:12 +0000	[thread overview]
Message-ID: <177412441253.2951219.3596535924088439799.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260314021521.128361-1-danjwade95@gmail.com>

Hello:

This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Sat, 14 Mar 2026 13:15:19 +1100 you wrote:
> maybe_fork_scalars() unconditionally sets the pushed path dst register
> to 0 for both BPF_AND and BPF_OR.  For AND this is correct (0 & K == 0),
> but for OR it is wrong (0 | K == K, not 0).  This causes the verifier to
> track an incorrect value on the pushed path, leading to a verifier/runtime
> divergence that allows out-of-bounds map value access.
> 
> v4: Use block comment style for multi-line comments in selftests (Amery Hung)
>     Add Reviewed-by/Acked-by tags
> v3: Use single-line comment style in selftests (Alexei Starovoitov)
> v2: Use push_stack(env, env->insn_idx, ...) to re-execute the insn
>     on the pushed path (Eduard Zingerman)
> 
> [...]

Here is the summary with links:
  - [bpf,v4,1/2] bpf: Fix unsound scalar forking in maybe_fork_scalars() for BPF_OR
    https://git.kernel.org/bpf/bpf/c/c845894ebd6f
  - [bpf,v4,2/2] selftests/bpf: Add tests for maybe_fork_scalars() OR vs AND handling
    https://git.kernel.org/bpf/bpf/c/0ad1734cc559

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-03-21 20:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14  2:15 [PATCH bpf v4 0/2] bpf: Fix unsound scalar forking for BPF_OR Daniel Wade
2026-03-14  2:15 ` [PATCH bpf v4 1/2] bpf: Fix unsound scalar forking in maybe_fork_scalars() " Daniel Wade
2026-03-14  2:15 ` [PATCH bpf v4 2/2] selftests/bpf: Add tests for maybe_fork_scalars() OR vs AND handling Daniel Wade
2026-03-21 20:20 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177412441253.2951219.3596535924088439799.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=ameryhung@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=danjwade95@gmail.com \
    --cc=eddyz87@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.