* [PATCH 0/2] Renesas: propagate platform_get_irq() error upstream
@ 2015-08-28 13:54 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2015-08-28 13:54 UTC (permalink / raw)
To: netdev; +Cc: linux-sh, horms
Hello.
Here's 2 patches against DaveM's 'net.git' repo. We fix error handling for
platform_get_irq() that overrides the error code with -ENODEV which e.g.
prevents the deferred probing from working.
[1/2] ravb: propagate platform_get_irq() error upstream
[2/2] sh_eth: propagate platform_get_irq() error upstream
MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 0/2] Renesas: propagate platform_get_irq() error upstream
@ 2015-08-28 13:54 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2015-08-28 13:54 UTC (permalink / raw)
To: netdev; +Cc: linux-sh, horms
Hello.
Here's 2 patches against DaveM's 'net.git' repo. We fix error handling for
platform_get_irq() that overrides the error code with -ENODEV which e.g.
prevents the deferred probing from working.
[1/2] ravb: propagate platform_get_irq() error upstream
[2/2] sh_eth: propagate platform_get_irq() error upstream
MBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] ravb: propagate platform_get_irq() error upstream
2015-08-28 13:54 ` Sergei Shtylyov
@ 2015-08-28 13:55 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2015-08-28 13:55 UTC (permalink / raw)
To: netdev; +Cc: linux-sh, horms
The driver overrides the error returned by platform_get_irq() with -ENODEV
which e.g. precludes the deferred probing from working. Propagate the real
error code to the driver core instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/ravb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net/drivers/net/ethernet/renesas/ravb_main.c
=================================--- net.orig/drivers/net/ethernet/renesas/ravb_main.c
+++ net/drivers/net/ethernet/renesas/ravb_main.c
@@ -1643,7 +1643,7 @@ static int ravb_probe(struct platform_de
ndev->dma = -1;
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- error = -ENODEV;
+ error = irq;
goto out_release;
}
ndev->irq = irq;
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/2] ravb: propagate platform_get_irq() error upstream
@ 2015-08-28 13:55 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2015-08-28 13:55 UTC (permalink / raw)
To: netdev; +Cc: linux-sh, horms
The driver overrides the error returned by platform_get_irq() with -ENODEV
which e.g. precludes the deferred probing from working. Propagate the real
error code to the driver core instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/ravb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net/drivers/net/ethernet/renesas/ravb_main.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/ravb_main.c
+++ net/drivers/net/ethernet/renesas/ravb_main.c
@@ -1643,7 +1643,7 @@ static int ravb_probe(struct platform_de
ndev->dma = -1;
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- error = -ENODEV;
+ error = irq;
goto out_release;
}
ndev->irq = irq;
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/2] ravb: propagate platform_get_irq() error upstream
2015-08-28 13:55 ` Sergei Shtylyov
@ 2015-08-28 15:38 ` Geert Uytterhoeven
-1 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2015-08-28 15:38 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev@vger.kernel.org, Linux-sh list, Simon Horman
On Fri, Aug 28, 2015 at 3:55 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/2] ravb: propagate platform_get_irq() error upstream
@ 2015-08-28 15:38 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2015-08-28 15:38 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev@vger.kernel.org, Linux-sh list, Simon Horman
On Fri, Aug 28, 2015 at 3:55 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ravb: propagate platform_get_irq() error upstream
2015-08-28 13:55 ` Sergei Shtylyov
@ 2015-08-29 5:26 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2015-08-29 5:26 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-sh, horms
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 28 Aug 2015 16:55:10 +0300
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] ravb: propagate platform_get_irq() error upstream
@ 2015-08-29 5:26 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2015-08-29 5:26 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-sh, horms
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 28 Aug 2015 16:55:10 +0300
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
2015-08-28 13:54 ` Sergei Shtylyov
@ 2015-08-28 13:56 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2015-08-28 13:56 UTC (permalink / raw)
To: netdev; +Cc: linux-sh, horms
The driver overrides the error returned by platform_get_irq() with -ENODEV
which e.g. precludes the deferred probing from working. Propagate the real
error code to the driver core instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
=================================--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -3089,10 +3089,8 @@ static int sh_eth_drv_probe(struct platf
ndev->dma = -1;
ret = platform_get_irq(pdev, 0);
- if (ret < 0) {
- ret = -ENODEV;
+ if (ret < 0)
goto out_release;
- }
ndev->irq = ret;
SET_NETDEV_DEV(ndev, &pdev->dev);
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
@ 2015-08-28 13:56 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2015-08-28 13:56 UTC (permalink / raw)
To: netdev; +Cc: linux-sh, horms
The driver overrides the error returned by platform_get_irq() with -ENODEV
which e.g. precludes the deferred probing from working. Propagate the real
error code to the driver core instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -3089,10 +3089,8 @@ static int sh_eth_drv_probe(struct platf
ndev->dma = -1;
ret = platform_get_irq(pdev, 0);
- if (ret < 0) {
- ret = -ENODEV;
+ if (ret < 0)
goto out_release;
- }
ndev->irq = ret;
SET_NETDEV_DEV(ndev, &pdev->dev);
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
2015-08-28 13:56 ` Sergei Shtylyov
@ 2015-08-28 15:39 ` Geert Uytterhoeven
-1 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2015-08-28 15:39 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev@vger.kernel.org, Linux-sh list, Simon Horman
On Fri, Aug 28, 2015 at 3:56 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
@ 2015-08-28 15:39 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2015-08-28 15:39 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev@vger.kernel.org, Linux-sh list, Simon Horman
On Fri, Aug 28, 2015 at 3:56 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
2015-08-28 13:56 ` Sergei Shtylyov
@ 2015-08-29 5:26 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2015-08-29 5:26 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-sh, horms
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 28 Aug 2015 16:56:01 +0300
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
@ 2015-08-29 5:26 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2015-08-29 5:26 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-sh, horms
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 28 Aug 2015 16:56:01 +0300
> The driver overrides the error returned by platform_get_irq() with -ENODEV
> which e.g. precludes the deferred probing from working. Propagate the real
> error code to the driver core instead.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-08-29 5:26 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-28 13:54 [PATCH 0/2] Renesas: propagate platform_get_irq() error upstream Sergei Shtylyov
2015-08-28 13:54 ` Sergei Shtylyov
2015-08-28 13:55 ` [PATCH 1/2] ravb: " Sergei Shtylyov
2015-08-28 13:55 ` Sergei Shtylyov
2015-08-28 15:38 ` Geert Uytterhoeven
2015-08-28 15:38 ` Geert Uytterhoeven
2015-08-29 5:26 ` David Miller
2015-08-29 5:26 ` David Miller
2015-08-28 13:56 ` [PATCH 2/2] sh_eth: " Sergei Shtylyov
2015-08-28 13:56 ` Sergei Shtylyov
2015-08-28 15:39 ` Geert Uytterhoeven
2015-08-28 15:39 ` Geert Uytterhoeven
2015-08-29 5:26 ` David Miller
2015-08-29 5:26 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.