All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Rik van Riel <riel@conectiva.com.br>,
	Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, wli@holomorphy.com
Subject: Re: [PATCH] for_each_zone / for_each_pgdat
Date: Mon, 15 Apr 2002 15:19:53 -0700	[thread overview]
Message-ID: <1774420000.1018909193@flay> (raw)
In-Reply-To: <Pine.LNX.4.44L.0204151755491.16531-100000@duckman.distro.conectiva>

> Because code that doesn't care about pgdats shouldn't have to
> learn about them, IMHO.  I used to have the doubly nested for
> loop in -rmap, but William Irwin came up with a way to make
> it a singly nested loop for code that only cares about zones.

Can't you just have the simple single and double loops in mmzone.h,
seperated by a #ifdef CONFIG_DISCONTIGMEM?

I like the general abstraction idea of where you're going though.
Is there a for_each_node already? Can't see one:

#define for_each_node(nid) \
	for (nid = 0; nid < numnodes; nid++)

would allow us to change the assumption that nodes are numbered
contiguously, starting from 0, more easily later on ... ?

M.


  parent reply	other threads:[~2002-04-15 21:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-15 15:49 [PATCH] for_each_zone / for_each_pgdat Rik van Riel
2002-04-15 20:49 ` Linus Torvalds
2002-04-15 20:58   ` Rik van Riel
2002-04-15 21:08     ` Linus Torvalds
2002-04-15 21:17       ` Linus Torvalds
2002-04-15 23:20         ` William Lee Irwin III
2002-04-16  0:44           ` Andrea Arcangeli
2002-04-16  1:30             ` Mike Fedyk
2002-04-16  4:27               ` Rik van Riel
2002-04-16 13:36                 ` Andrea Arcangeli
2002-04-16 13:44               ` Andrea Arcangeli
2002-04-16 16:39                 ` Mike Fedyk
2002-04-16 14:00               ` Bill Davidsen
2002-04-16 18:19                 ` Mike Fedyk
2002-04-16  4:22             ` Marcelo Tosatti
2002-04-16 14:50         ` Oliver Xymoron
2002-04-16 14:56           ` Rik van Riel
2002-04-16 15:26             ` Oliver Xymoron
2002-04-16 15:46             ` J.A. Magallon
2002-04-15 21:18       ` Christoph Hellwig
2002-04-15 21:47       ` Rik van Riel
2002-04-15 22:19     ` Martin J. Bligh [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-04-12  0:25 Rik van Riel
2002-04-18  9:41 ` Pavel Machek
2002-04-11 18:23 Rik van Riel
2002-04-11 18:54 ` Rik van Riel
2002-04-12  0:07 ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1774420000.1018909193@flay \
    --to=martin.bligh@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.