From: patchwork-bot+netdevbpf@kernel.org
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: linux-ppp@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, gnault@redhat.com, wojciech.drewek@intel.com,
anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, paulus@ozlabs.org, jaco@uls.co.za,
carlsonj@workingcode.com, marcin.szycik@linux.intel.com
Subject: Re: [PATCH net v6 1/2] flow_dissector: do not dissect PPPoE PFC frames
Date: Mon, 20 Apr 2026 21:59:40 +0000 [thread overview]
Message-ID: <177672238004.1802062.14523487791539173606.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260415022456.141758-1-qingfang.deng@linux.dev>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 15 Apr 2026 10:24:50 +0800 you wrote:
> RFC 2516 Section 7 states that Protocol Field Compression (PFC) is NOT
> RECOMMENDED for PPPoE. In practice, pppd does not support negotiating
> PFC for PPPoE sessions, and the flow dissector driver has assumed an
> uncompressed frame until the blamed commit.
>
> During the review process of that commit [1], support for PFC is
> suggested. However, having a compressed (1-byte) protocol field means
> the subsequent PPP payload is shifted by one byte, causing 4-byte
> misalignment for the network header and an unaligned access exception
> on some architectures.
>
> [...]
Here is the summary with links:
- [net,v6,1/2] flow_dissector: do not dissect PPPoE PFC frames
https://git.kernel.org/netdev/net/c/d6c19b31a3c1
- [net,v6,2/2] pppoe: drop PFC frames
https://git.kernel.org/netdev/net/c/cc1ff87bce1c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-04-20 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 2:24 [PATCH net v6 1/2] flow_dissector: do not dissect PPPoE PFC frames Qingfang Deng
2026-04-15 2:24 ` [PATCH net v6 2/2] pppoe: drop " Qingfang Deng
2026-04-18 19:11 ` Jakub Kicinski
2026-04-19 7:53 ` Qingfang Deng
2026-04-15 13:42 ` [PATCH net v6 1/2] flow_dissector: do not dissect PPPoE " Qingfang Deng
2026-04-16 16:17 ` Jakub Kicinski
2026-04-20 21:59 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177672238004.1802062.14523487791539173606.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=carlsonj@workingcode.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=jaco@uls.co.za \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@ozlabs.org \
--cc=qingfang.deng@linux.dev \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.