From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 1/7] drm: Add fb_helper->restore_fbdev_mode
	hook
Date: Wed, 08 May 2013 14:42:27 +0200
Message-ID: <1776838.kA4PF15PTK@avalon>
References: <1368006922-24957-1-git-send-email-ville.syrjala@linux.intel.com>
	<1368006922-24957-2-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <1368006922-24957-2-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Ville,

Thank you for the patch.

On Wednesday 08 May 2013 12:55:16 ville.syrjala@linux.intel.com wrote:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Drivers may need to turn off overlay planes, cursors, etc. when
> restoring the fbdev mode. So allow drivers to provide their own
> version of drm_fb_helper_restore_fbdev_mode() that can take care
> of such details.
> =

> Initially just plug in drm_fb_helper_restore_fbdev_mode for all
> drivers.
> =

> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/ast/ast_fb.c              | 1 +
>  drivers/gpu/drm/cirrus/cirrus_fbdev.c     | 1 +
>  drivers/gpu/drm/drm_fb_cma_helper.c       | 1 +
>  drivers/gpu/drm/drm_fb_helper.c           | 2 +-
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 +
>  drivers/gpu/drm/gma500/framebuffer.c      | 1 +
>  drivers/gpu/drm/i915/intel_fb.c           | 1 +
>  drivers/gpu/drm/mgag200/mgag200_fb.c      | 1 +
>  drivers/gpu/drm/nouveau/nouveau_fbcon.c   | 1 +
>  drivers/gpu/drm/omapdrm/omap_fbdev.c      | 1 +
>  drivers/gpu/drm/qxl/qxl_fb.c              | 1 +
>  drivers/gpu/drm/radeon/radeon_fb.c        | 1 +
>  drivers/gpu/drm/udl/udl_fb.c              | 1 +
>  include/drm/drm_fb_helper.h               | 1 +
>  14 files changed, 14 insertions(+), 1 deletion(-)

[snip]

> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 8230b46..9f5b9be 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -72,6 +72,7 @@ struct drm_fb_helper_funcs {
>  			       struct drm_fb_helper_crtc **crtcs,
>  			       struct drm_display_mode **modes,
>  			       bool *enabled, int width, int height);
> +	bool (*restore_fbdev_mode)(struct drm_fb_helper *fb_helper);

Could you please document this new function in the struct drm_fb_helper_fun=
cs =

kerneldoc block ?

>  };
> =

>  struct drm_fb_helper_connector {
-- =

Regards,

Laurent Pinchart