From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACF51EB64DD for ; Mon, 7 Aug 2023 11:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pp4GjZ9+7GfWrSendNVdXxaqlveJAgLfxyEmBVIxEAY=; b=EVXc1+97aWiald Y+UNTpEjKjRDD63ylQXfiCLUgAag04+/kpEzC+0tUVFqh5WIPA+LM6v6adkPaNsREPDlESoSD6FVm zr5S3Gj5Ru3KjkAe7GZa2+ys7jfw8KVNoGYgblrofLhn9EU2c91Qo7Ms1yr7m/bGYCcokrPBCF2ik 40V9JvijqXtGpW8ovogYNwGoapDgPrsXp8SJfuKVdVjFJJau6zLp5cV38bV5jJYi3VCgFjITJ1je6 oDk81KX+SPn/RxGHa5gGlc9PxMyaStwApErxk+F/Lbx8O8q61XNkyeWBlnB2W/mrHXhAp/sPppupp xJ8S99ycsL2LJiUTndKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSyYJ-00H6ra-3B; Mon, 07 Aug 2023 11:37:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSyYG-00H6qP-1v for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 11:37:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 578BA1FB; Mon, 7 Aug 2023 04:38:12 -0700 (PDT) Received: from [10.57.90.63] (unknown [10.57.90.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A82633F59C; Mon, 7 Aug 2023 04:37:27 -0700 (PDT) Message-ID: <177702e7-e68f-fa7a-4507-48dc82fcc030@arm.com> Date: Mon, 7 Aug 2023 12:37:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 4/4] coresight: trbe: Enable ACPI based TRBE devices To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Sami Mujawar , Catalin Marinas , Will Deacon , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230803055652.1322801-1-anshuman.khandual@arm.com> <20230803055652.1322801-5-anshuman.khandual@arm.com> From: Suzuki K Poulose In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_043732_727080_2A8CACD3 X-CRM114-Status: GOOD ( 23.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDcvMDgvMjAyMyAwNTo0MywgQW5zaHVtYW4gS2hhbmR1YWwgd3JvdGU6Cj4gCj4gCj4gT24g OC8zLzIzIDExOjI2LCBBbnNodW1hbiBLaGFuZHVhbCB3cm90ZToKPj4gVGhpcyBkZXRlY3RzIGFu ZCBlbmFibGVzIEFDUEkgYmFzZWQgVFJCRSBkZXZpY2VzIHZpYSB0aGUgZHVtbXkgcGxhdGZvcm0K Pj4gZGV2aWNlIGNyZWF0ZWQgZWFybGllciBmb3IgdGhpcyBwdXJwb3NlLgo+Pgo+PiBDYzogU3V6 dWtpIEsgUG91bG9zZSA8c3V6dWtpLnBvdWxvc2VAYXJtLmNvbT4KPj4gQ2M6IE1pa2UgTGVhY2gg PG1pa2UubGVhY2hAbGluYXJvLm9yZz4KPj4gQ2M6IExlbyBZYW4gPGxlby55YW5AbGluYXJvLm9y Zz4KPj4gQ2M6IEFsZXhhbmRlciBTaGlzaGtpbiA8YWxleGFuZGVyLnNoaXNoa2luQGxpbnV4Lmlu dGVsLmNvbT4KPj4gQ2M6IGNvcmVzaWdodEBsaXN0cy5saW5hcm8ub3JnCj4+IENjOiBsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPj4gQ2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtl cm5lbC5vcmcKPj4gU2lnbmVkLW9mZi1ieTogQW5zaHVtYW4gS2hhbmR1YWwgPGFuc2h1bWFuLmto YW5kdWFsQGFybS5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9j b3Jlc2lnaHQtdHJiZS5jIHwgOSArKysrKysrKysKPj4gICBkcml2ZXJzL2h3dHJhY2luZy9jb3Jl c2lnaHQvY29yZXNpZ2h0LXRyYmUuaCB8IDEgKwo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0 L2NvcmVzaWdodC10cmJlLmMgYi9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0 LXRyYmUuYwo+PiBpbmRleCBlMWQ5ZDA2ZTc3MjUuLmY4ODQ4ODNlOTAxOCAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC10cmJlLmMKPj4gKysrIGIv ZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC10cmJlLmMKPj4gQEAgLTE1Mzcs NyArMTUzNywxNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBhcm1fdHJiZV9v Zl9tYXRjaFtdID0gewo+PiAgIH07Cj4+ICAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgYXJtX3Ry YmVfb2ZfbWF0Y2gpOwo+PiAgIAo+PiArI2lmZGVmIENPTkZJR19BQ1BJCj4+ICtzdGF0aWMgY29u c3Qgc3RydWN0IHBsYXRmb3JtX2RldmljZV9pZCBhcm1fdHJiZV9hY3BpX21hdGNoW10gPSB7Cj4+ ICsJeyBBUk1WOF9UUkJFX1BERVZfTkFNRSwgMCB9LAo+PiArCXsgfQo+PiArfTsKPj4gK01PRFVM RV9ERVZJQ0VfVEFCTEUocGxhdGZvcm0sIGFybV90cmJlX2FjcGlfbWF0Y2gpOwo+PiArI2VuZGlm Cj4+ICsKPj4gICBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBhcm1fdHJiZV9kcml2ZXIg PSB7Cj4+ICsJLmlkX3RhYmxlID0gYXJtX3RyYmVfYWNwaV9tYXRjaCwKPiAKPiBUaGUgYnVpbGQg cHJvYmxlbSBbMV0gcmVwb3J0ZWQgb24gdGhlIGZpcnN0IHZlcnNpb24gb2YgdGhlIHNlcmllcyBz dGlsbCBleGlzdHMKPiBoZXJlIGkuZSBhcm1fdHJiZV9hY3BpX21hdGNoIGlzIGhpZGRlbiB3aXRo b3V0IENPTkZJR19BQ1BJLiBJIGhhZCBhc3N1bWVkIHRoYXQKPiBDT05GSUdfQ09SRVNJR0hUIGFs d2F5cyBlbmFibGVzIENPTkZJR19BQ1BJLCB3aGljaCBpcyBub3QgdGhlIGNhc2UuIEZvbGxvd2lu Zwo+IHJhbmRvbSBjb25maWcgKHdpdGggQ09ORklHX0FDUEk9biBhbmQgQ09ORklHX0NPUkVTSUdI VF9UUkJFPXkpIGVhc2lseSB0cmlnZ2Vycwo+IHRoZSBidWlsZCBwcm9ibGVtLgo+IAo+IGh0dHBz Oi8vZG93bmxvYWQuMDEub3JnLzBkYXktY2kvYXJjaGl2ZS8yMDIzMDgwNS8yMDIzMDgwNTIxMjMu dXFSMzVkMTktbGtwQGludGVsLmNvbS9jb25maWcKPiAKPiAgIG1ha2UgQ1JPU1NfQ09NUElMRT1h YXJjaDY0LWxpbnV4LWdudS0gQVJDSD1hcm02NCAtcyAtaiAxMjgKPiBkcml2ZXJzL2h3dHJhY2lu Zy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuYzoxNTYzOjIzOiBlcnJvcjogaW1wbGljaXQgZGVj bGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYQUNQSV9QVFLigJkgWy1XZXJyb3I9aW1wbGljaXQtZnVu Y3Rpb24tZGVjbGFyYXRpb25dCj4gICAxNTYzIHwgICAuYWNwaV9tYXRjaF90YWJsZSA9IEFDUElf UFRSKGFybV90cmJlX2FjcGlfbWF0Y2gpLAo+ICAgICAgICB8ICAgICAgICAgICAgICAgICAgICAg ICBefn5+fn5+fgo+IGRyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5j OjE1NjM6MzI6IGVycm9yOiDigJhhcm1fdHJiZV9hY3BpX21hdGNo4oCZIHVuZGVjbGFyZWQgaGVy ZSAobm90IGluIGEgZnVuY3Rpb24pOyBkaWQgeW91IG1lYW4g4oCYYXJtX3RyYmVfb2ZfbWF0Y2ji gJk/Cj4gICAxNTYzIHwgICAuYWNwaV9tYXRjaF90YWJsZSA9IEFDUElfUFRSKGFybV90cmJlX2Fj cGlfbWF0Y2gpLAo+ICAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+ fn5+fn5+fn5+fn5+fn5+Cj4gICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGFybV90cmJlX29mX21hdGNoCj4gCj4gRm9sbG93aW5nIGNvbmZpZyB3cmFwIGFyb3VuZCBmaXhl cyB0aGUgcHJvYmxlbS4KPiAKPiAtLS0gYS9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29y ZXNpZ2h0LXRyYmUuYwo+ICsrKyBiL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2ln aHQtdHJiZS5jCj4gQEAgLTE1NTcsNyArMTU1Nyw5IEBAIE1PRFVMRV9ERVZJQ0VfVEFCTEUocGxh dGZvcm0sIGFybV90cmJlX2FjcGlfbWF0Y2gpOwo+ICAgI2VuZGlmCj4gICAKPiAgIHN0YXRpYyBz dHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGFybV90cmJlX2RyaXZlciA9IHsKPiArI2lmZGVmIENPTkZJ R19BQ1BJCj4gICAgICAgICAgLmlkX3RhYmxlID0gYXJtX3RyYmVfYWNwaV9tYXRjaCwKPiArI2Vu ZGlmCj4gICAgICAgICAgLmRyaXZlciA9IHsKPiAgICAgICAgICAgICAgICAgIC5uYW1lID0gRFJW TkFNRSwKPiAgICAgICAgICAgICAgICAgIC5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX3B0cihh cm1fdHJiZV9vZl9tYXRjaCksCj4gCj4gUGxlYXNlIG5vdCB0aGF0IHVubGlrZSBvdGhlciBjb3Jl c2lnaHQgZHJpdmVycywgVFJCRSBpcyBub3QgdXNpbmcgJ2FjcGlfZGV2aWNlX2lkJwo+IGJhc2Vk ICJhY3BpX21hdGNoX3RhYmxlID0gQUNQSV9QVFIiIGNvbnN0cnVjdC4gQnV0IHJlZ2FyZGxlc3Ms IEFDUElfUFRSKCkgc2VlbXMgdG8KPiBiZSBhbiBhbHRlcm5hdGUgKHByb2JhYmx5IGJldHRlcikg c29sdXRpb24gYXMgd2VsbC4KPiAKPiAtLS0gYS9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQv Y29yZXNpZ2h0LXRyYmUuYwo+ICsrKyBiL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jl c2lnaHQtdHJiZS5jCj4gQEAgLTE1NTcsNyArMTU1Nyw3IEBAIE1PRFVMRV9ERVZJQ0VfVEFCTEUo cGxhdGZvcm0sIGFybV90cmJlX2FjcGlfbWF0Y2gpOwo+ICAgI2VuZGlmCj4gICAKPiAgIHN0YXRp YyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGFybV90cmJlX2RyaXZlciA9IHsKPiAtICAgICAgIC5p ZF90YWJsZSA9IGFybV90cmJlX2FjcGlfbWF0Y2gsCj4gKyAgICAgICAuaWRfdGFibGUgPSBBQ1BJ X1BUUihhcm1fdHJiZV9hY3BpX21hdGNoKSwKClRoaXMgaXMgcHJlZmVycmVkLgoKPiAgICAgICAg ICAuZHJpdmVyID0gewo+ICAgICAgICAgICAgICAgICAgLm5hbWUgPSBEUlZOQU1FLAo+ICAgICAg ICAgICAgICAgICAgLm9mX21hdGNoX3RhYmxlID0gb2ZfbWF0Y2hfcHRyKGFybV90cmJlX29mX21h dGNoKSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdo dC10cmJlLmggYi9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuaAo+ IGluZGV4IDk0ZTY3MDA5ODQ4YS4uZmNlMTczNWQ1YzU4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv aHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5oCj4gKysrIGIvZHJpdmVycy9od3Ry YWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC10cmJlLmgKPiBAQCAtNyw2ICs3LDcgQEAKPiAgICAq Cj4gICAgKiBBdXRob3I6IEFuc2h1bWFuIEtoYW5kdWFsIDxhbnNodW1hbi5raGFuZHVhbEBhcm0u Y29tPgo+ICAgICovCj4gKyNpbmNsdWRlIDxsaW51eC9hY3BpLmg+CgpTaG91bGRuJ3QgdGhpcyBi ZSBhZGRlZCBpbiB0cmJlLmMgPyBEb2VzIHRyYmUuaCBkZXBlbmQgb24gYW55IEFDUEkgaGVhZGVy cyA/CgpTdXp1a2kKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEFBC001DF for ; Mon, 7 Aug 2023 11:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbjHGLlq (ORCPT ); Mon, 7 Aug 2023 07:41:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232825AbjHGLlc (ORCPT ); Mon, 7 Aug 2023 07:41:32 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5304F46BA for ; Mon, 7 Aug 2023 04:38:38 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 578BA1FB; Mon, 7 Aug 2023 04:38:12 -0700 (PDT) Received: from [10.57.90.63] (unknown [10.57.90.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A82633F59C; Mon, 7 Aug 2023 04:37:27 -0700 (PDT) Message-ID: <177702e7-e68f-fa7a-4507-48dc82fcc030@arm.com> Date: Mon, 7 Aug 2023 12:37:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 4/4] coresight: trbe: Enable ACPI based TRBE devices To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Sami Mujawar , Catalin Marinas , Will Deacon , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230803055652.1322801-1-anshuman.khandual@arm.com> <20230803055652.1322801-5-anshuman.khandual@arm.com> From: Suzuki K Poulose In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2023 05:43, Anshuman Khandual wrote: > > > On 8/3/23 11:26, Anshuman Khandual wrote: >> This detects and enables ACPI based TRBE devices via the dummy platform >> device created earlier for this purpose. >> >> Cc: Suzuki K Poulose >> Cc: Mike Leach >> Cc: Leo Yan >> Cc: Alexander Shishkin >> Cc: coresight@lists.linaro.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> drivers/hwtracing/coresight/coresight-trbe.c | 9 +++++++++ >> drivers/hwtracing/coresight/coresight-trbe.h | 1 + >> 2 files changed, 10 insertions(+) >> >> diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c >> index e1d9d06e7725..f884883e9018 100644 >> --- a/drivers/hwtracing/coresight/coresight-trbe.c >> +++ b/drivers/hwtracing/coresight/coresight-trbe.c >> @@ -1537,7 +1537,16 @@ static const struct of_device_id arm_trbe_of_match[] = { >> }; >> MODULE_DEVICE_TABLE(of, arm_trbe_of_match); >> >> +#ifdef CONFIG_ACPI >> +static const struct platform_device_id arm_trbe_acpi_match[] = { >> + { ARMV8_TRBE_PDEV_NAME, 0 }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(platform, arm_trbe_acpi_match); >> +#endif >> + >> static struct platform_driver arm_trbe_driver = { >> + .id_table = arm_trbe_acpi_match, > > The build problem [1] reported on the first version of the series still exists > here i.e arm_trbe_acpi_match is hidden without CONFIG_ACPI. I had assumed that > CONFIG_CORESIGHT always enables CONFIG_ACPI, which is not the case. Following > random config (with CONFIG_ACPI=n and CONFIG_CORESIGHT_TRBE=y) easily triggers > the build problem. > > https://download.01.org/0day-ci/archive/20230805/202308052123.uqR35d19-lkp@intel.com/config > > make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 -s -j 128 > drivers/hwtracing/coresight/coresight-trbe.c:1563:23: error: implicit declaration of function ‘ACPI_PTR’ [-Werror=implicit-function-declaration] > 1563 | .acpi_match_table = ACPI_PTR(arm_trbe_acpi_match), > | ^~~~~~~~ > drivers/hwtracing/coresight/coresight-trbe.c:1563:32: error: ‘arm_trbe_acpi_match’ undeclared here (not in a function); did you mean ‘arm_trbe_of_match’? > 1563 | .acpi_match_table = ACPI_PTR(arm_trbe_acpi_match), > | ^~~~~~~~~~~~~~~~~~~ > | arm_trbe_of_match > > Following config wrap around fixes the problem. > > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -1557,7 +1557,9 @@ MODULE_DEVICE_TABLE(platform, arm_trbe_acpi_match); > #endif > > static struct platform_driver arm_trbe_driver = { > +#ifdef CONFIG_ACPI > .id_table = arm_trbe_acpi_match, > +#endif > .driver = { > .name = DRVNAME, > .of_match_table = of_match_ptr(arm_trbe_of_match), > > Please not that unlike other coresight drivers, TRBE is not using 'acpi_device_id' > based "acpi_match_table = ACPI_PTR" construct. But regardless, ACPI_PTR() seems to > be an alternate (probably better) solution as well. > > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -1557,7 +1557,7 @@ MODULE_DEVICE_TABLE(platform, arm_trbe_acpi_match); > #endif > > static struct platform_driver arm_trbe_driver = { > - .id_table = arm_trbe_acpi_match, > + .id_table = ACPI_PTR(arm_trbe_acpi_match), This is preferred. > .driver = { > .name = DRVNAME, > .of_match_table = of_match_ptr(arm_trbe_of_match), > diff --git a/drivers/hwtracing/coresight/coresight-trbe.h b/drivers/hwtracing/coresight/coresight-trbe.h > index 94e67009848a..fce1735d5c58 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.h > +++ b/drivers/hwtracing/coresight/coresight-trbe.h > @@ -7,6 +7,7 @@ > * > * Author: Anshuman Khandual > */ > +#include Shouldn't this be added in trbe.c ? Does trbe.h depend on any ACPI headers ? Suzuki