From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH] drm/i915: Check fb stride against plane max stride Date: Mon, 24 Sep 2018 11:56:20 -0700 Message-ID: <1777080.k0ixM5hEeS@dk> References: <20180918140243.12207-1-ville.syrjala@linux.intel.com> <2577088.l8ySodvzlW@dk> <20180924133156.GQ5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40DA06E046 for ; Mon, 24 Sep 2018 18:56:30 +0000 (UTC) In-Reply-To: <20180924133156.GQ5565@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uZGF5LCBTZXB0ZW1iZXIgMjQsIDIwMTggNjozMTo1NiBBTSBQRFQgVmlsbGUgU3lyasOk bMOkIHdyb3RlOgo+IE9uIEZyaSwgU2VwIDIxLCAyMDE4IGF0IDAzOjE3OjQ1UE0gLTA3MDAsIERo aW5ha2FyYW4gUGFuZGl5YW4gd3JvdGU6Cj4gPiBPbiBUdWVzZGF5LCBTZXB0ZW1iZXIgMTgsIDIw MTggNzowMjo0MyBBTSBQRFQgVmlsbGUgU3lyamFsYSB3cm90ZToKPiA+ID4gRnJvbTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gCj4gPiA+IGNv bW1pdCA0ZTBiODNhNTY3ZTIgKCJkcm0vaTkxNTogRXh0cmFjdCBwZXItcGxhdGZvcm0gcGxhbmUt PmNoZWNrKCkKPiA+ID4gZnVuY3Rpb25zIikgcmVtb3ZlZCB0aGUgcGxhbmUgbWF4IHN0cmlkZSBj aGVjayBmb3Igc3ByaXRlIHBsYW5lcy4KPiA+ID4gSSB3YXMgZ29pbmcgdG8gYWRkIGl0IGJhY2sg d2hlbiBpbnRyb2R1Y2luZyBHVFQgcmVtYXBwaW5nIGZvciB0aGUKPiA+ID4gZGlzcGxheSwgYnV0 IGFmdGVyIGZ1cnRoZXIgdGhvdWdodCBpdCBzZWVtcyBiZXR0ZXIgdG8gcmUtaW50cm9kdWNlCj4g PiA+IGl0IHNlcGFyYXRlbHkuCj4gPiA+IAo+ID4gPiBTbyBsZXQncyBhZGQgdGhlIG1heCBzdHJp ZGUgY2hlY2sgYmFjay4gQW5kIGxldCdzIGRvIGl0IGluIGEgbmljZXIKPiA+ID4gZm9ybSB0aGFu IHdoYXQgd2UgaGFkIGJlZm9yZSBhbmQgZG8gaXQgZm9yIGFsbCBwbGFuZSB0eXBlcyAoZWFzeQo+ ID4gPiBub3cgdGhhdCB3ZSBoYXZlIHRoZSAtPm1heF9zdHJpZGUoKSBwbGFuZSB2ZnVuYykuCj4g PiA+IAo+ID4gPiBPbmx5IHNwcml0ZSBwbGFuZXMgcmVhbGx5IG5lZWQgdGhpcyBmb3Igbm93IHNp bmNlIHByaW1hcnkgcGxhbmVzCj4gPiA+IGFyZSBjYXBhYmxlIG9mIHNjYW5uaW5nIG91dCB0aGUg Y3VycmVudCBtYXggZmIgc2l6ZSB3ZSBhbGxvdywgYW5kCj4gPiA+IGN1cnNvcnMgaGF2ZSBtb3Jl IHN0cmluZ2VudCBzdHJpZGUgY2hlY2tzIGVsc2V3aGVyZS4KPiA+ID4gCgpSZXZpZXdlZC1ieTog RGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cgo+ID4g PiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gPiA+ IEZpeGVzOiA0ZTBiODNhNTY3ZTIgKCJkcm0vaTkxNTogRXh0cmFjdCBwZXItcGxhdGZvcm0gcGxh bmUtPmNoZWNrKCkKPiA+ID4gZnVuY3Rpb25zIikgU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+IAo+ID4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTQgKysrKysrKysrKysr KysKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAxICsKPiA+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jICB8IDIyICsrKysrKysrKysr KysrKysrKysrKysKPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKQo+ID4g PiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBpbmRleCBlYjI1 MDM3ZDdiMzguLjFlYjk5ZDVlYzIyMQo+ID4gPiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiBAQCAtMzE1MSw2ICszMTUxLDEwIEBAIGludCBza2xf Y2hlY2tfcGxhbmVfc3VyZmFjZShzdHJ1Y3QKPiA+ID4gaW50ZWxfcGxhbmVfc3RhdGUKPiA+ID4g KnBsYW5lX3N0YXRlKSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0uc3RyaWRlID0gaW50ZWxf ZmJfcGl0Y2goZmIsIDAsCj4gPiA+IHJvdGF0aW9uKTsgcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5l WzFdLnN0cmlkZSA9IGludGVsX2ZiX3BpdGNoKGZiLCAxLAo+ID4gPiByb3RhdGlvbik7Cj4gPiA+ IAo+ID4gPiArCXJldCA9IGludGVsX3BsYW5lX2NoZWNrX3N0cmlkZShwbGFuZV9zdGF0ZSk7Cj4g PiA+ICsJaWYgKHJldCkKPiA+ID4gKwkJcmV0dXJuIHJldDsKPiA+ID4gKwo+ID4gPiAKPiA+ID4g IAlpZiAoIXBsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUpCj4gPiA+ICAJCj4gPiA+ICAJCXJldHVy biAwOwo+ID4gPiAKPiA+ID4gQEAgLTMyODYsMTAgKzMyOTAsMTUgQEAgaW50IGk5eHhfY2hlY2tf cGxhbmVfc3VyZmFjZShzdHJ1Y3QKPiA+ID4gaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRl KSBpbnQgc3JjX3ggPSBwbGFuZV9zdGF0ZS0+YmFzZS5zcmMueDEgPj4KPiA+ID4gMTY7Cj4gPiA+ IAo+ID4gPiAgCWludCBzcmNfeSA9IHBsYW5lX3N0YXRlLT5iYXNlLnNyYy55MSA+PiAxNjsKPiA+ ID4gIAl1MzIgb2Zmc2V0Owo+ID4gPiAKPiA+ID4gKwlpbnQgcmV0Owo+ID4gPiAKPiA+ID4gIAlp bnRlbF9maWxsX2ZiX2dndHRfdmlldygmcGxhbmVfc3RhdGUtPnZpZXcsIGZiLCByb3RhdGlvbik7 Cj4gPiA+ICAJcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lWzBdLnN0cmlkZSA9IGludGVsX2ZiX3Bp dGNoKGZiLCAwLCByb3RhdGlvbik7Cj4gPiAKPiA+IElzIHRoZXJlIGEgZ29vZCByZWFzb24gdG8g bm90ICBpbmxpbmUgdGhlIGNvZGUgPwo+ID4gCj4gPiAJaWYgKGNvbG9yX3BsYW5lWzBdLnN0cmlk ZSA+IHBsYW5lLT5tYXhfc3RyaWRlKCkpCj4gPiAJCj4gPiAJCXJldHVybiAtRUlOVkFMOwo+IAo+ IENvbnNpc3RlbmN5LiBFYXNpZXIgdG8ganVzdCBjYWxsIGEgc2luZ2xlIGZ1bmN0aW9uIHRoYXQg ZG9lcyB0aGluZ3MgaW4gYQo+IGNvbnNpc3RlbnQgZmFzaGlvbiByYXRoZXIgdGhhbiBkdXBsaWNh dGluZyB0aGUgc2FtZSBjaGVjayBldmVyeXdoZXJlLgo+IEFsc28ga2VlcHMgdGhlIGRlYnVnIHBy aW50IGNvbnNpc3RlbnQuCj4gCj4gPiA+ICsJcmV0ID0gaW50ZWxfcGxhbmVfY2hlY2tfc3RyaWRl KHBsYW5lX3N0YXRlKTsKPiA+ID4gKwlpZiAocmV0KQo+ID4gPiArCQlyZXR1cm4gcmV0Owo+ID4g PiArCj4gPiA+IAo+ID4gPiAgCWludGVsX2FkZF9mYl9vZmZzZXRzKCZzcmNfeCwgJnNyY195LCBw bGFuZV9zdGF0ZSwgMCk7Cj4gPiA+ICAJCj4gPiA+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gNCkKPiA+ID4gCj4gPiA+IEBAIC05Njg1LDEwICs5Njk0LDE1IEBAIHN0YXRpYyBpbnQgaW50 ZWxfY3Vyc29yX2NoZWNrX3N1cmZhY2Uoc3RydWN0Cj4gPiA+IGludGVsX3BsYW5lX3N0YXRlICpw bGFuZV9zdGF0ZSkgdW5zaWduZWQgaW50IHJvdGF0aW9uID0KPiA+ID4gcGxhbmVfc3RhdGUtPmJh c2Uucm90YXRpb247Cj4gPiA+IAo+ID4gPiAgCWludCBzcmNfeCwgc3JjX3k7Cj4gPiA+ICAJdTMy IG9mZnNldDsKPiA+ID4gCj4gPiA+ICsJaW50IHJldDsKPiA+ID4gCj4gPiA+ICAJaW50ZWxfZmls bF9mYl9nZ3R0X3ZpZXcoJnBsYW5lX3N0YXRlLT52aWV3LCBmYiwgcm90YXRpb24pOwo+ID4gPiAg CXBsYW5lX3N0YXRlLT5jb2xvcl9wbGFuZVswXS5zdHJpZGUgPSBpbnRlbF9mYl9waXRjaChmYiwg MCwgcm90YXRpb24pOwo+ID4gPiAKPiA+ID4gKwlyZXQgPSBpbnRlbF9wbGFuZV9jaGVja19zdHJp ZGUocGxhbmVfc3RhdGUpOwo+ID4gPiArCWlmIChyZXQpCj4gPiA+ICsJCXJldHVybiByZXQ7Cj4g PiA+ICsKPiA+ID4gCj4gPiA+ICAJc3JjX3ggPSBwbGFuZV9zdGF0ZS0+YmFzZS5zcmNfeCA+PiAx NjsKPiA+ID4gIAlzcmNfeSA9IHBsYW5lX3N0YXRlLT5iYXNlLnNyY195ID4+IDE2Owo+ID4gPiAK PiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiA+ IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggaW5kZXggYmYxYzM4NzI4YTU5Li5h MzRjMmYxZjkxNTkKPiA+ID4gMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4gPiA+IEBAIC0yMTQwLDYgKzIxNDAsNyBAQCB1bnNpZ25lZCBpbnQgc2tsX3BsYW5lX21heF9z dHJpZGUoc3RydWN0Cj4gPiA+IGludGVsX3BsYW5lCj4gPiA+ICpwbGFuZSwgdW5zaWduZWQgaW50 IHJvdGF0aW9uKTsKPiA+ID4gCj4gPiA+ICBpbnQgc2tsX3BsYW5lX2NoZWNrKHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4gPiAgCj4gPiA+ICAJCSAgICBzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKTsKPiA+ID4gCj4gPiA+ICtpbnQgaW50ZWxfcGxh bmVfY2hlY2tfc3RyaWRlKGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZQo+ID4gPiAqcGxh bmVfc3RhdGUpOwo+ID4gPiAKPiA+ID4gIGludCBpbnRlbF9wbGFuZV9jaGVja19zcmNfY29vcmRp bmF0ZXMoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlCj4gPiA+IAo+ID4gPiAqcGxhbmVfc3RhdGUp OyBpbnQgY2h2X3BsYW5lX2NoZWNrX3JvdGF0aW9uKGNvbnN0IHN0cnVjdAo+ID4gPiBpbnRlbF9w bGFuZV9zdGF0ZQo+ID4gPiAqcGxhbmVfc3RhdGUpOwo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+IGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgaW5kZXggZDRjOGUxMGZjOTBiLi41ZmQyZjdiZjM5MjcK PiA+ID4gMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0 ZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiA+ IEBAIC0yMzAsNiArMjMwLDI4IEBAIHZvaWQgaW50ZWxfcGlwZV91cGRhdGVfZW5kKHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlCj4gPiA+ICpuZXdfY3J0Y19zdGF0ZSkgI2VuZGlmCj4gPiA+IAo+ID4g PiAgfQo+ID4gPiAKPiA+ID4gK2ludCBpbnRlbF9wbGFuZV9jaGVja19zdHJpZGUoY29uc3Qgc3Ry dWN0IGludGVsX3BsYW5lX3N0YXRlCj4gPiA+ICpwbGFuZV9zdGF0ZSkKPiA+ID4gK3sKPiA+ID4g KwlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmVfc3RhdGUt PmJhc2UucGxhbmUpOwo+ID4gPiArCWNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0g cGxhbmVfc3RhdGUtPmJhc2UuZmI7Cj4gPiA+ICsJdW5zaWduZWQgaW50IHJvdGF0aW9uID0gcGxh bmVfc3RhdGUtPmJhc2Uucm90YXRpb247Cj4gPiA+ICsJdTMyIHN0cmlkZSwgbWF4X3N0cmlkZTsK PiA+ID4gKwo+ID4gPiArCS8qIEZJWE1FIG90aGVyIGNvbG9yIHBsYW5lcz8gKi8KPiA+IAo+ID4g RG9lc24ndCB0aGUgY29sb3IgcGxhbmUgMCBoYXZlIHRoZSBtYXggc3RyaWRlIGFsd2F5cz8KPiAK PiBFYWNoIGNvbG9yIHBsYW5lIGNvdWxkIGhhdmUgYSBkaWZmZXJlbnQgbWF4aW11bS4gRGVwZW5k cyBvbiB0aGUgaHcuCj4gTm90IHRoYXQgaXQncyBhY3R1YWxseSBkb2N1bWVudGVkIGZvciB0aGUg c2tsKyBhdXggc3VyZmFjZS4gV291bGQKPiBwcm9iYWJseSBuZWVkIHRvIHRlc3Qgd2hhdCBpcyB0 aGUgbWF4LCBvciBqdXN0IHBpY2sgYSBzZW5zaWJsZQo+IGxpbWl0IHRoYXQgc3RpbGwgc2VlbXMg dG8gd29yay4KPiAKPiA+ID4gKwlzdHJpZGUgPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0u c3RyaWRlOwo+ID4gPiArCW1heF9zdHJpZGUgPSBwbGFuZS0+bWF4X3N0cmlkZShwbGFuZSwgZmIt PmZvcm1hdC0+Zm9ybWF0LAo+ID4gPiArCQkJCSAgICAgICBmYi0+bW9kaWZpZXIsIHJvdGF0aW9u KTsKPiA+ID4gKwo+ID4gPiArCWlmIChzdHJpZGUgPiBtYXhfc3RyaWRlKSB7Cj4gPiA+ICsJCURS TV9ERUJVR19LTVMoIltGQjolZF0gc3RyaWRlICglZCkgZXhjZWVkcyBbUExBTkU6JWQ6JXNdIG1h eCBzdHJpZGUKPiA+ID4gKCVkKVxuIiwgKwkJCSAgICAgIGZiLT5iYXNlLmlkLCBzdHJpZGUsCj4g PiA+ICsJCQkgICAgICBwbGFuZS0+YmFzZS5iYXNlLmlkLCBwbGFuZS0+YmFzZS5uYW1lLCBtYXhf c3RyaWRlKTsKPiA+IAo+ID4gSW5jbHVkZSB0aGUgY29sb3IgcGxhbmUgbnVtYmVyIGluIHRoZSBk ZWJ1ZyBwcmludD8KPiAKPiBJIHN1cHBvc2UuCj4gCj4gPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ ID4gPiArCX0KPiA+ID4gKwo+ID4gPiArCXJldHVybiAwOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ IAo+ID4gPiAgaW50IGludGVsX3BsYW5lX2NoZWNrX3NyY19jb29yZGluYXRlcyhzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUKPiA+ID4gCj4gPiA+ICpwbGFuZV9zdGF0ZSkgewo+ID4gPiAKPiA+ID4g IAljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNlLmZi OwoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==