From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Declan Doherty <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] bond: vlan flags misinterpreted in xmit_slave_hash function
Date: Thu, 15 Jan 2015 14:40:12 +0100 [thread overview]
Message-ID: <1777245.1puKfUUkev@xps13> (raw)
In-Reply-To: <1418733910-18253-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> This patch contains a fix for link bonding handling of vlan tagged packets in mode 3 and 5.
> Currently xmit_slave_hash function misinterprets the PKT_RX_VLAN_PKT flag to mean that
> there is a vlan tag within the packet when in actually means that there is a valid entry
> in the vlan_tci field in the mbuf.
>
> -v2:
> doxygen comments for rte_ip.h
>
> - Fixed VLAN tag support in hashing functions.
> - Adds support for TCP in layer 4 header hashing.
> - Splits transmit hashing function into separate functions for each policy to
> reduce branching and to make the code clearer.
> - Fixed incorrect flag set in test application packet generator.
>
> Signed-off-by: Declan Doherty <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Acked-by: Pawel Wodkowski <pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Tested-by: SunX Jiajia <sunx.jiajia-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Applied
Thanks
--
Thomas
prev parent reply other threads:[~2015-01-15 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:15 [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function Declan Doherty
[not found] ` <1418728549-31244-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-16 11:22 ` Thomas Monjalon
2014-12-16 11:44 ` Wodkowski, PawelX
2014-12-16 12:45 ` [PATCH v2] " Declan Doherty
[not found] ` <1418733910-18253-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-07 2:50 ` Jiajia, SunX
2015-01-15 13:40 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1777245.1puKfUUkev@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.