All of lore.kernel.org
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] obexd: Remove unused parameter from manager_request_authorization
Date: Wed, 08 Apr 2015 12:39:21 +0200	[thread overview]
Message-ID: <1778487.jXsPSmtx9k@leonov> (raw)
In-Reply-To: <1426160579-9281-1-git-send-email-szymon.janc@tieto.com>

On Thursday 12 of March 2015 12:42:59 Szymon Janc wrote:
> This fix compilation error with musl due to missing (now not needed)
> stdint.h include.
> ---
>  obexd/plugins/opp.c | 4 +---
>  obexd/src/manager.c | 2 +-
>  obexd/src/manager.h | 2 +-
>  3 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/obexd/plugins/opp.c b/obexd/plugins/opp.c
> index 5228ba8..445688d 100644
> --- a/obexd/plugins/opp.c
> +++ b/obexd/plugins/opp.c
> @@ -62,7 +62,6 @@ static void opp_progress(struct obex_session *os, void
> *user_data) static int opp_chkput(struct obex_session *os, void *user_data)
>  {
>  	char *folder, *name, *path;
> -	int32_t time;
>  	const char *t;
>  	int err;
> 
> @@ -79,8 +78,7 @@ static int opp_chkput(struct obex_session *os, void
> *user_data) goto skip_auth;
>  	}
> 
> -	time = 0;
> -	err = manager_request_authorization(user_data, time, &folder, &name);
> +	err = manager_request_authorization(user_data, &folder, &name);
>  	if (err < 0)
>  		return -EPERM;
> 
> diff --git a/obexd/src/manager.c b/obexd/src/manager.c
> index 371f127..f84384a 100644
> --- a/obexd/src/manager.c
> +++ b/obexd/src/manager.c
> @@ -671,7 +671,7 @@ static gboolean auth_error(GIOChannel *io, GIOCondition
> cond, void *user_data) return FALSE;
>  }
> 
> -int manager_request_authorization(struct obex_transfer *transfer, int32_t
> time, +int manager_request_authorization(struct obex_transfer *transfer,
> char **new_folder, char **new_name)
>  {
>  	struct obex_session *os = transfer->session;
> diff --git a/obexd/src/manager.h b/obexd/src/manager.h
> index 669b223..d9781b2 100644
> --- a/obexd/src/manager.h
> +++ b/obexd/src/manager.h
> @@ -36,7 +36,7 @@ void manager_unregister_transfer(struct obex_transfer
> *transfer); void manager_emit_transfer_started(struct obex_transfer
> *transfer); void manager_emit_transfer_progress(struct obex_transfer
> *transfer); void manager_emit_transfer_completed(struct obex_transfer
> *transfer); -int manager_request_authorization(struct obex_transfer
> *transfer, int32_t time, +int manager_request_authorization(struct
> obex_transfer *transfer, char **new_folder, char **new_name);
> 
>  DBusConnection *manager_dbus_get_connection(void);

Applied.
-- 
BR
Szymon Janc

      reply	other threads:[~2015-04-08 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 11:42 [PATCH] obexd: Remove unused parameter from manager_request_authorization Szymon Janc
2015-04-08 10:39 ` Szymon Janc [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1778487.jXsPSmtx9k@leonov \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.