From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Xiao" <xiao.zhang@intel.com>
Cc: stable@dpdk.org, "Hunt, David" <david.hunt@intel.com>,
dev@dpdk.org, "Liu, Yong" <yong.liu@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] examples/l3fwd-power: fix RX interrupt disable
Date: Sun, 27 Oct 2019 18:39:47 +0100 [thread overview]
Message-ID: <1779321.6W3n8sOxgi@xps> (raw)
In-Reply-To: <17d41a58-909a-0650-eac2-0ffe33081ca8@intel.com>
24/10/2019 10:07, Hunt, David:
>
> On 23/10/2019 15:32, Thomas Monjalon wrote:
> > +Cc Dave, the maintainer
> >
> >>> Interrupt will not be received when disabling RX interrupt without
> >>> synchronization mechanism sometimes which leads to wake up issue,
> >>> add spinlock to fix it.
> >>>
> >>> Fixes: b736d64787fc ("mples/l3fwd-power: disable Rx interrupt when
> >>> waking up")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> >> Reviewed-by: Marvin Liu <yong.liu@intel.com>
>
> This makes sense, as the corresponding rte_eth_dev_rx_intr_enable()
> already has a spinlock around it.
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-10-27 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 16:10 [dpdk-dev] examples/l3fwd-power: fix RX interrupt disable Xiao Zhang
2019-09-20 5:22 ` Liu, Yong
2019-10-23 14:32 ` Thomas Monjalon
2019-10-24 8:07 ` Hunt, David
2019-10-27 17:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1779321.6W3n8sOxgi@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiao.zhang@intel.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.