From: Thomas Schmitt via Grub-devel <grub-devel@gnu.org>
To: grub-devel@gnu.org
Cc: Thomas Schmitt <scdbackup@gmx.net>, development@efficientek.com
Subject: Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt
Date: Sun, 06 Oct 2024 08:48:49 +0200 [thread overview]
Message-ID: <17793329718253394234@scdbackup.webframe.org> (raw)
In-Reply-To: <20241005151158.59588006@crass-HP-ZBook-15-G2>
Hi,
Glenn Washburn wrote:
> > > if [ -z "$debug" ] && [ "$RET" -eq "$xfail" ]; then
I wrote:
> > If indeed in a successful --xfail test RET must have the value of "$xfail"
> > (i guess 1), then it is concise and sufficient.
> [...] the only acceptable xfail case is for RET=1. If
> RET is greater than 1, that should be considered a hard error (iow a
> failure of the test itself and not the thing being tested).
How about calling the variable "expected_ret" instead of "xfail" ?
This would express in the code that rogue return values are really
intended to prevent deletion of the test data.
Have a nice day
Thomas
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2024-10-06 6:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 5:53 [PATCH 0/4] Various test fixes proposed by Thomas Schmitt Glenn Washburn
2024-09-23 5:53 ` [PATCH 1/4] tests/util/grub-shell-luks-tester: Add missing line to create RET variable in cleanup Glenn Washburn
2024-09-23 16:36 ` Thomas Schmitt via Grub-devel
2024-09-24 7:21 ` Thomas Schmitt via Grub-devel
2024-09-23 5:53 ` [PATCH 2/4] tests: Cleaup the cryptsetup script in grub_cmd_cryptomount unless debug is enabled Glenn Washburn
2024-09-23 5:53 ` [PATCH 3/4] tests: Default TMPDIR to /tmp in grub_cmd_cryptomount tests Glenn Washburn
2024-09-23 5:53 ` [PATCH 4/4] tests/util/grub-shell: Remove the work directory on successful run and debug is not on Glenn Washburn
2024-09-23 15:52 ` [PATCH 0/4] Various test fixes proposed by Thomas Schmitt Thomas Schmitt via Grub-devel
2024-09-26 19:19 ` Glenn Washburn
2024-09-26 20:44 ` Thomas Schmitt via Grub-devel
2024-09-26 22:21 ` Glenn Washburn
2024-09-27 11:59 ` Thomas Schmitt via Grub-devel
2024-10-01 3:49 ` Glenn Washburn
2024-10-02 7:08 ` Thomas Schmitt via Grub-devel
2024-10-05 20:11 ` Glenn Washburn
2024-10-06 6:48 ` Thomas Schmitt via Grub-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17793329718253394234@scdbackup.webframe.org \
--to=grub-devel@gnu.org \
--cc=development@efficientek.com \
--cc=scdbackup@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.