From: patchwork-bot+netdevbpf@kernel.org
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, eperezma@redhat.com,
virtualization@lists.linux.dev, kuba@kernel.org,
linux-kernel@vger.kernel.org, xuanzhuo@linux.alibaba.com,
mst@redhat.com, kvm@vger.kernel.org, pabeni@redhat.com,
jasowang@redhat.com, horms@kernel.org, stefanha@redhat.com,
edumazet@google.com, david.laight.linux@gmail.com
Subject: Re: [PATCH RESEND net] Revert "vsock/virtio: fix skb overhead overflow on 32-bit builds"
Date: Thu, 28 May 2026 22:10:57 +0000 [thread overview]
Message-ID: <178000625714.1533055.10719008699075181524.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260527171046.130211-1-sgarzare@redhat.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 27 May 2026 19:10:46 +0200 you wrote:
> From: Stefano Garzarella <sgarzare@redhat.com>
>
> This reverts commit 4157501b9a8f ("vsock/virtio: fix skb overhead
> overflow on 32-bit builds"). The fix was semantically correct (although
> it would have been better to use mul_u32_u32(), as David pointed out),
> but in practice we are estimating the memory used to allocate the SKBs,
> and this will never cause a 32-bit variable to overflow on a 32-bit
> system, since the memory would have run out long before that. On 64-bit,
> SKB_TRUESIZE() already evaluates to size_t, so the multiplication is
> already in 64-bit arithmetic without the cast.
>
> [...]
Here is the summary with links:
- [RESEND,net] Revert "vsock/virtio: fix skb overhead overflow on 32-bit builds"
https://git.kernel.org/netdev/net-next/c/e03f0b53b4bd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-05-28 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 17:10 [PATCH RESEND net] Revert "vsock/virtio: fix skb overhead overflow on 32-bit builds" Stefano Garzarella
2026-05-27 17:21 ` Michael S. Tsirkin
2026-05-27 18:09 ` David Laight
2026-05-28 22:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178000625714.1533055.10719008699075181524.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.