From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Date: Tue, 12 Nov 2019 09:10:42 +0100 Message-ID: <1780044.CQmMckQ5VN@diego> References: <20191111005158.25070-1-kever.yang@rock-chips.com> <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org To: Kever Yang Cc: Soeren Moch , linux-rockchip@lists.infradead.org, Elaine Zhang , Peter Robinson , Akash Gajjar , Alexis Ballier , Andrius =?utf-8?B?xaB0aWtvbmFz?= , Andy Yan , Ezequiel Garcia , Hugh Cole-Baker , Katsuhiro Suzuki , Mark Rutland , Nick Xie , Oskari Lemmela , Pragnesh Patel , Rob Herring , Robin Murphy , Vicente Bergas , Vivek Unune , devicetree@vger.kernel.orglinux List-Id: linux-rockchip.vger.kernel.org Hi Kever, Am Dienstag, 12. November 2019, 09:04:49 CET schrieb Kever Yang: > > On 2019/11/11 下午4:42, Soeren Moch wrote: > > On 11.11.19 01:51, Kever Yang wrote: > >> Since there is no devfreq used for vdd_log, so the vdd_log(pwm regulator) > >> will be 'enable' with the dts node at a default PWM state with high or low > >> output. Both too high or too low for vdd_log is not good for the board, > >> add init voltage for driver to make the regulator get into a know output. > >> > >> Note that this will be used by U-Boot for init voltage output, and this > >> is very important for it may get system hang somewhere during system > >> boot up with regulator enable and without this init value. > > I think it's a good idea to include this setting in the main dts for the > > boards (not in u-boot specific additions as is done now). But there is > > (for some reason?) no documented binding for regulator-init-microvolt in > > linux. > > > Ohh, I forgot the kernel driver does not support this property. > > @Heiko, can we add this 'regulator-init-microvolt' without driver > support but adding document for > > it at dt-binding? In theory yes, but you would still need to get DT maintainers and Mark Brown (regulator maintainer) involved before that. Especially as this is a individual property you will need to have a good excuse why you're not implementing it in the kernel as well. And of course you will need to keep in mind that it might be in the kernel in the future. Heiko > > > Thanks, > > - Kever > > > > > Regards, > > Soeren > >> CC: Elaine Zhang > >> CC: Peter Robinson > >> Signed-off-by: Kever Yang > >> --- > >> > >> arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 1 + > >> 9 files changed, 9 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >> index 77008dca45bc..fa241aeb11b0 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >> @@ -65,6 +65,7 @@ > >> regulator-name = "vdd_center"; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> regulator-always-on; > >> regulator-boot-on; > >> status = "okay"; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > >> index 92de83dd4dbc..4e45269fcdff 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > >> @@ -208,6 +208,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <430000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > >> index c133e8d64b2a..692f3154edc3 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > >> @@ -100,6 +100,7 @@ > >> regulator-name = "vdd_log"; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> regulator-always-on; > >> regulator-boot-on; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > >> index 4944d78a0a1c..c2ac80d99301 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > >> @@ -79,6 +79,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vsys_3v3>; > >> }; > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts b/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts > >> index 73be38a53796..c32abcc4ddc1 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts > >> @@ -101,6 +101,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc5v0_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts > >> index 0541dfce924d..9d674c51f025 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts > >> @@ -164,6 +164,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > >> index 19f7732d728c..7d856ce1d156 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > >> @@ -129,6 +129,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc3v3_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> index e544deb61d28..8fbccbc8bf47 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> @@ -174,6 +174,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1700000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc5v0_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > >> index 1bc1579674e5..f8e2cb8c0624 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > >> @@ -133,6 +133,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc_sys>; > >> }; > >> }; > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D31C43331 for ; Tue, 12 Nov 2019 08:11:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4D5121925 for ; Tue, 12 Nov 2019 08:11:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZRm5C73R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4D5121925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N5tk2DKGTlGZpZBZrN6zgiHPPlpBKaCtC+d2rDrY2qU=; b=ZRm5C73Rn2kWdk 6sDqbq0BIVkEkwwHrr8tSaMNWGIiq6qXjfJ8Sy5cquIVncZ4P6HDvFqkUX6674l+JUZ8d/OwphFWW c7rLTBfGh23773I2Y6/6S3sZAvghqhc911eaxiZ9plOyID2i9hmLdR/VAlw1tldRZdS7ayjDhExzk R7HsxL7pQHcCo9U3rhe0voyy87m418KzEa3gABlbIOLlK/uhnUWrJgIHXZUrZRLN/oP1GhF5HgCQe jn5wEFkO+ZmungWA6UHTA4JookhqQK/ZfSZ4YJ0fsMBcGojPK3nTjst39EpILsEhIT09+RAaLGSMV SYzBVl9EwRuK5p+d66Ag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURGm-00086k-LT; Tue, 12 Nov 2019 08:11:24 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURGj-00085Y-Cr; Tue, 12 Nov 2019 08:11:23 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iURG8-0005gt-0H; Tue, 12 Nov 2019 09:10:44 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Kever Yang Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Date: Tue, 12 Nov 2019 09:10:42 +0100 Message-ID: <1780044.CQmMckQ5VN@diego> In-Reply-To: <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> References: <20191111005158.25070-1-kever.yang@rock-chips.com> <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_001121_592818_C93D1206 X-CRM114-Status: GOOD ( 20.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alexis Ballier , dianders@chromium.org, Soeren Moch , Hugh Cole-Baker , Andy Yan , Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, Pragnesh Patel , Peter Robinson , Nick Xie , devicetree@vger.kernel.org, Elaine Zhang , Vicente Bergas , Rob Herring , Akash Gajjar , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Andrius =?utf-8?B?xaB0aWtvbmFz?= , linux-kernel@vger.kernel.org, Oskari Lemmela , Robin Murphy , Vivek Unune Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS2V2ZXIsCgpBbSBEaWVuc3RhZywgMTIuIE5vdmVtYmVyIDIwMTksIDA5OjA0OjQ5IENFVCBz Y2hyaWViIEtldmVyIFlhbmc6Cj4gCj4gT24gMjAxOS8xMS8xMSDkuIvljYg0OjQyLCBTb2VyZW4g TW9jaCB3cm90ZToKPiA+IE9uIDExLjExLjE5IDAxOjUxLCBLZXZlciBZYW5nIHdyb3RlOgo+ID4+ IFNpbmNlIHRoZXJlIGlzIG5vIGRldmZyZXEgdXNlZCBmb3IgdmRkX2xvZywgc28gdGhlIHZkZF9s b2cocHdtIHJlZ3VsYXRvcikKPiA+PiB3aWxsIGJlICdlbmFibGUnIHdpdGggdGhlIGR0cyBub2Rl IGF0IGEgZGVmYXVsdCBQV00gc3RhdGUgd2l0aCBoaWdoIG9yIGxvdwo+ID4+IG91dHB1dC4gQm90 aCB0b28gaGlnaCBvciB0b28gbG93IGZvciB2ZGRfbG9nIGlzIG5vdCBnb29kIGZvciB0aGUgYm9h cmQsCj4gPj4gYWRkIGluaXQgdm9sdGFnZSBmb3IgZHJpdmVyIHRvIG1ha2UgdGhlIHJlZ3VsYXRv ciBnZXQgaW50byBhIGtub3cgb3V0cHV0Lgo+ID4+Cj4gPj4gTm90ZSB0aGF0IHRoaXMgd2lsbCBi ZSB1c2VkIGJ5IFUtQm9vdCBmb3IgaW5pdCB2b2x0YWdlIG91dHB1dCwgYW5kIHRoaXMKPiA+PiBp cyB2ZXJ5IGltcG9ydGFudCBmb3IgaXQgbWF5IGdldCBzeXN0ZW0gaGFuZyBzb21ld2hlcmUgZHVy aW5nIHN5c3RlbQo+ID4+IGJvb3QgdXAgd2l0aCByZWd1bGF0b3IgZW5hYmxlIGFuZCB3aXRob3V0 IHRoaXMgaW5pdCB2YWx1ZS4KPiA+IEkgdGhpbmsgaXQncyBhIGdvb2QgaWRlYSB0byBpbmNsdWRl IHRoaXMgc2V0dGluZyBpbiB0aGUgbWFpbiBkdHMgZm9yIHRoZQo+ID4gYm9hcmRzIChub3QgaW4g dS1ib290IHNwZWNpZmljIGFkZGl0aW9ucyBhcyBpcyBkb25lIG5vdykuIEJ1dCB0aGVyZSBpcwo+ ID4gKGZvciBzb21lIHJlYXNvbj8pIG5vIGRvY3VtZW50ZWQgYmluZGluZyBmb3IgcmVndWxhdG9y LWluaXQtbWljcm92b2x0IGluCj4gPiBsaW51eC4KPiAKPiAKPiBPaGgsIEkgZm9yZ290IHRoZSBr ZXJuZWwgZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgdGhpcyBwcm9wZXJ0eS4KPiAKPiBASGVpa28s IGNhbiB3ZSBhZGQgdGhpcyAncmVndWxhdG9yLWluaXQtbWljcm92b2x0JyB3aXRob3V0IGRyaXZl ciAKPiBzdXBwb3J0IGJ1dCBhZGRpbmcgZG9jdW1lbnQgZm9yCj4gCj4gaXQgYXQgZHQtYmluZGlu Zz8KCkluIHRoZW9yeSB5ZXMsIGJ1dCB5b3Ugd291bGQgc3RpbGwgbmVlZCB0byBnZXQgRFQgbWFp bnRhaW5lcnMKYW5kIE1hcmsgQnJvd24gKHJlZ3VsYXRvciBtYWludGFpbmVyKSBpbnZvbHZlZCBi ZWZvcmUgdGhhdC4KCkVzcGVjaWFsbHkgYXMgdGhpcyBpcyBhIGluZGl2aWR1YWwgcHJvcGVydHkg eW91IHdpbGwgbmVlZCB0byBoYXZlCmEgZ29vZCBleGN1c2Ugd2h5IHlvdSdyZSBub3QgaW1wbGVt ZW50aW5nIGl0IGluIHRoZSBrZXJuZWwgYXMgd2VsbC4KCkFuZCBvZiBjb3Vyc2UgeW91IHdpbGwg bmVlZCB0byBrZWVwIGluIG1pbmQgdGhhdCBpdCBtaWdodCBiZQppbiB0aGUga2VybmVsIGluIHRo ZSBmdXR1cmUuCgoKSGVpa28KCgoKPiAKPiAKPiBUaGFua3MsCj4gCj4gLSBLZXZlcgo+IAo+ID4K PiA+IFJlZ2FyZHMsCj4gPiBTb2VyZW4KPiA+PiBDQzogRWxhaW5lIFpoYW5nIDx6aGFuZ3FpbmdA cm9jay1jaGlwcy5jb20+Cj4gPj4gQ0M6IFBldGVyIFJvYmluc29uIDxwYnJvYmluc29uQGdtYWls LmNvbT4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBLZXZlciBZYW5nIDxrZXZlci55YW5nQHJvY2stY2hp cHMuY29tPgo+ID4+IC0tLQo+ID4+Cj4gPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzM5OS1ldmIuZHRzICAgICAgICAgIHwgMSArCj4gPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRz L3JvY2tjaGlwL3JrMzM5OS1maXJlZmx5LmR0cyAgICAgIHwgMSArCj4gPj4gICBhcmNoL2FybTY0 L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1odWdzdW4teDk5LmR0cyAgIHwgMSArCj4gPj4gICBh cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1raGFkYXMtZWRnZS5kdHNpIHwgMSAr Cj4gPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1sZWV6LXA3MTAuZHRz ICAgIHwgMSArCj4gPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1vcmFu Z2VwaS5kdHMgICAgIHwgMSArCj4gPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzM5OS1yb2MtcGMuZHRzICAgICAgIHwgMSArCj4gPj4gICBhcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3JrMzM5OS1yb2NrcHJvNjQuZHRzICAgIHwgMSArCj4gPj4gICBhcmNoL2FybTY0L2Jv b3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1zYXBwaGlyZS5kdHNpICAgIHwgMSArCj4gPj4gICA5IGZp bGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gv YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWV2Yi5kdHMgYi9hcmNoL2FybTY0L2Jvb3Qv ZHRzL3JvY2tjaGlwL3JrMzM5OS1ldmIuZHRzCj4gPj4gaW5kZXggNzcwMDhkY2E0NWJjLi5mYTI0 MWFlYjExYjAgMTAwNjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9y azMzOTktZXZiLmR0cwo+ID4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmsz Mzk5LWV2Yi5kdHMKPiA+PiBAQCAtNjUsNiArNjUsNyBAQAo+ID4+ICAgCQlyZWd1bGF0b3ItbmFt ZSA9ICJ2ZGRfY2VudGVyIjsKPiA+PiAgIAkJcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8ODAw MDAwPjsKPiA+PiAgIAkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTQwMDAwMD47Cj4gPj4g KwkJcmVndWxhdG9yLWluaXQtbWljcm92b2x0ID0gPDk1MDAwMD47Cj4gPj4gICAJCXJlZ3VsYXRv ci1hbHdheXMtb247Cj4gPj4gICAJCXJlZ3VsYXRvci1ib290LW9uOwo+ID4+ICAgCQlzdGF0dXMg PSAib2theSI7Cj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LWZpcmVmbHkuZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTkt ZmlyZWZseS5kdHMKPiA+PiBpbmRleCA5MmRlODNkZDRkYmMuLjRlNDUyNjlmY2RmZiAxMDA2NDQK PiA+PiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1maXJlZmx5LmR0 cwo+ID4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWZpcmVmbHku ZHRzCj4gPj4gQEAgLTIwOCw2ICsyMDgsNyBAQAo+ID4+ICAgCQlyZWd1bGF0b3ItYm9vdC1vbjsK PiA+PiAgIAkJcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8NDMwMDAwPjsKPiA+PiAgIAkJcmVn dWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTQwMDAwMD47Cj4gPj4gKwkJcmVndWxhdG9yLWluaXQt bWljcm92b2x0ID0gPDk1MDAwMD47Cj4gPj4gICAJCXZpbi1zdXBwbHkgPSA8JnZjY19zeXM+Owo+ ID4+ICAgCX07Cj4gPj4gICB9Owo+ID4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRz L3JvY2tjaGlwL3JrMzM5OS1odWdzdW4teDk5LmR0cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszMzk5LWh1Z3N1bi14OTkuZHRzCj4gPj4gaW5kZXggYzEzM2U4ZDY0YjJhLi42OTJm MzE1NGVkYzMgMTAwNjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9y azMzOTktaHVnc3VuLXg5OS5kdHMKPiA+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tj aGlwL3JrMzM5OS1odWdzdW4teDk5LmR0cwo+ID4+IEBAIC0xMDAsNiArMTAwLDcgQEAKPiA+PiAg IAkJcmVndWxhdG9yLW5hbWUgPSAidmRkX2xvZyI7Cj4gPj4gICAJCXJlZ3VsYXRvci1taW4tbWlj cm92b2x0ID0gPDgwMDAwMD47Cj4gPj4gICAJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDE0 MDAwMDA+Owo+ID4+ICsJCXJlZ3VsYXRvci1pbml0LW1pY3Jvdm9sdCA9IDw5NTAwMDA+Owo+ID4+ ICAgCQlyZWd1bGF0b3ItYWx3YXlzLW9uOwo+ID4+ICAgCQlyZWd1bGF0b3ItYm9vdC1vbjsKPiA+ PiAgIAl9Owo+ID4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzM5OS1raGFkYXMtZWRnZS5kdHNpIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMz OTkta2hhZGFzLWVkZ2UuZHRzaQo+ID4+IGluZGV4IDQ5NDRkNzhhMGExYy4uYzJhYzgwZDk5MzAx IDEwMDY0NAo+ID4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LWto YWRhcy1lZGdlLmR0c2kKPiA+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzM5OS1raGFkYXMtZWRnZS5kdHNpCj4gPj4gQEAgLTc5LDYgKzc5LDcgQEAKPiA+PiAgIAkJcmVn dWxhdG9yLWJvb3Qtb247Cj4gPj4gICAJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDgwMDAw MD47Cj4gPj4gICAJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDE0MDAwMDA+Owo+ID4+ICsJ CXJlZ3VsYXRvci1pbml0LW1pY3Jvdm9sdCA9IDw5NTAwMDA+Owo+ID4+ICAgCQl2aW4tc3VwcGx5 ID0gPCZ2c3lzXzN2Mz47Cj4gPj4gICAJfTsKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9hcmNoL2Fy bTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1sZWV6LXA3MTAuZHRzIGIvYXJjaC9hcm02NC9i b290L2R0cy9yb2NrY2hpcC9yazMzOTktbGVlei1wNzEwLmR0cwo+ID4+IGluZGV4IDczYmUzOGE1 Mzc5Ni4uYzMyYWJjYzRkZGMxIDEwMDY0NAo+ID4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszMzk5LWxlZXotcDcxMC5kdHMKPiA+PiArKysgYi9hcmNoL2FybTY0L2Jvb3Qv ZHRzL3JvY2tjaGlwL3JrMzM5OS1sZWV6LXA3MTAuZHRzCj4gPj4gQEAgLTEwMSw2ICsxMDEsNyBA QAo+ID4+ICAgCQlyZWd1bGF0b3ItYm9vdC1vbjsKPiA+PiAgIAkJcmVndWxhdG9yLW1pbi1taWNy b3ZvbHQgPSA8ODAwMDAwPjsKPiA+PiAgIAkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTQw MDAwMD47Cj4gPj4gKwkJcmVndWxhdG9yLWluaXQtbWljcm92b2x0ID0gPDk1MDAwMD47Cj4gPj4g ICAJCXZpbi1zdXBwbHkgPSA8JnZjYzV2MF9zeXM+Owo+ID4+ICAgCX07Cj4gPj4gICB9Owo+ID4+ IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1vcmFuZ2Vw aS5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1vcmFuZ2VwaS5kdHMK PiA+PiBpbmRleCAwNTQxZGZjZTkyNGQuLjlkNjc0YzUxZjAyNSAxMDA2NDQKPiA+PiAtLS0gYS9h cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1vcmFuZ2VwaS5kdHMKPiA+PiArKysg Yi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1vcmFuZ2VwaS5kdHMKPiA+PiBA QCAtMTY0LDYgKzE2NCw3IEBACj4gPj4gICAJCXJlZ3VsYXRvci1ib290LW9uOwo+ID4+ICAgCQly ZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDw4MDAwMDA+Owo+ID4+ICAgCQlyZWd1bGF0b3ItbWF4 LW1pY3Jvdm9sdCA9IDwxNDAwMDAwPjsKPiA+PiArCQlyZWd1bGF0b3ItaW5pdC1taWNyb3ZvbHQg PSA8OTUwMDAwPjsKPiA+PiAgIAkJdmluLXN1cHBseSA9IDwmdmNjX3N5cz47Cj4gPj4gICAJfTsK PiA+PiAgIH07Cj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LXJvYy1wYy5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1y b2MtcGMuZHRzCj4gPj4gaW5kZXggMTlmNzczMmQ3MjhjLi43ZDg1NmNlMWQxNTYgMTAwNjQ0Cj4g Pj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMzOTktcm9jLXBjLmR0cwo+ ID4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LXJvYy1wYy5kdHMK PiA+PiBAQCAtMTI5LDYgKzEyOSw3IEBACj4gPj4gICAJCXJlZ3VsYXRvci1ib290LW9uOwo+ID4+ ICAgCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDw4MDAwMDA+Owo+ID4+ICAgCQlyZWd1bGF0 b3ItbWF4LW1pY3Jvdm9sdCA9IDwxNDAwMDAwPjsKPiA+PiArCQlyZWd1bGF0b3ItaW5pdC1taWNy b3ZvbHQgPSA8OTUwMDAwPjsKPiA+PiAgIAkJdmluLXN1cHBseSA9IDwmdmNjM3YzX3N5cz47Cj4g Pj4gICAJfTsKPiA+PiAgIH07Cj4gPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszMzk5LXJvY2twcm82NC5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tj aGlwL3JrMzM5OS1yb2NrcHJvNjQuZHRzCj4gPj4gaW5kZXggZTU0NGRlYjYxZDI4Li44ZmJjY2Jj OGJmNDcgMTAwNjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazMz OTktcm9ja3BybzY0LmR0cwo+ID4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAv cmszMzk5LXJvY2twcm82NC5kdHMKPiA+PiBAQCAtMTc0LDYgKzE3NCw3IEBACj4gPj4gICAJCXJl Z3VsYXRvci1ib290LW9uOwo+ID4+ICAgCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDw4MDAw MDA+Owo+ID4+ICAgCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwxNzAwMDAwPjsKPiA+PiAr CQlyZWd1bGF0b3ItaW5pdC1taWNyb3ZvbHQgPSA8OTUwMDAwPjsKPiA+PiAgIAkJdmluLXN1cHBs eSA9IDwmdmNjNXYwX3N5cz47Cj4gPj4gICAJfTsKPiA+PiAgIH07Cj4gPj4gZGlmZiAtLWdpdCBh L2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LXNhcHBoaXJlLmR0c2kgYi9hcmNo L2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS1zYXBwaGlyZS5kdHNpCj4gPj4gaW5kZXgg MWJjMTU3OTY3NGU1Li5mOGUyY2I4YzA2MjQgMTAwNjQ0Cj4gPj4gLS0tIGEvYXJjaC9hcm02NC9i b290L2R0cy9yb2NrY2hpcC9yazMzOTktc2FwcGhpcmUuZHRzaQo+ID4+ICsrKyBiL2FyY2gvYXJt NjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszMzk5LXNhcHBoaXJlLmR0c2kKPiA+PiBAQCAtMTMzLDYg KzEzMyw3IEBACj4gPj4gICAJCXJlZ3VsYXRvci1ib290LW9uOwo+ID4+ICAgCQlyZWd1bGF0b3It bWluLW1pY3Jvdm9sdCA9IDw4MDAwMDA+Owo+ID4+ICAgCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9s dCA9IDwxNDAwMDAwPjsKPiA+PiArCQlyZWd1bGF0b3ItaW5pdC1taWNyb3ZvbHQgPSA8OTUwMDAw PjsKPiA+PiAgIAkJdmluLXN1cHBseSA9IDwmdmNjX3N5cz47Cj4gPj4gICAJfTsKPiA+PiAgIH07 Cj4gCj4gCj4gCgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE61C43331 for ; Tue, 12 Nov 2019 08:11:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D594821925 for ; Tue, 12 Nov 2019 08:11:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725283AbfKLILY convert rfc822-to-8bit (ORCPT ); Tue, 12 Nov 2019 03:11:24 -0500 Received: from gloria.sntech.de ([185.11.138.130]:57632 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfKLILY (ORCPT ); Tue, 12 Nov 2019 03:11:24 -0500 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iURG8-0005gt-0H; Tue, 12 Nov 2019 09:10:44 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Kever Yang Cc: Soeren Moch , linux-rockchip@lists.infradead.org, Elaine Zhang , Peter Robinson , Akash Gajjar , Alexis Ballier , Andrius =?utf-8?B?xaB0aWtvbmFz?= , Andy Yan , Ezequiel Garcia , Hugh Cole-Baker , Katsuhiro Suzuki , Mark Rutland , Nick Xie , Oskari Lemmela , Pragnesh Patel , Rob Herring , Robin Murphy , Vicente Bergas , Vivek Unune , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dianders@chromium.org Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Date: Tue, 12 Nov 2019 09:10:42 +0100 Message-ID: <1780044.CQmMckQ5VN@diego> In-Reply-To: <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> References: <20191111005158.25070-1-kever.yang@rock-chips.com> <1eaef5d5-c923-da56-b9c4-48d517b3c969@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Kever, Am Dienstag, 12. November 2019, 09:04:49 CET schrieb Kever Yang: > > On 2019/11/11 下午4:42, Soeren Moch wrote: > > On 11.11.19 01:51, Kever Yang wrote: > >> Since there is no devfreq used for vdd_log, so the vdd_log(pwm regulator) > >> will be 'enable' with the dts node at a default PWM state with high or low > >> output. Both too high or too low for vdd_log is not good for the board, > >> add init voltage for driver to make the regulator get into a know output. > >> > >> Note that this will be used by U-Boot for init voltage output, and this > >> is very important for it may get system hang somewhere during system > >> boot up with regulator enable and without this init value. > > I think it's a good idea to include this setting in the main dts for the > > boards (not in u-boot specific additions as is done now). But there is > > (for some reason?) no documented binding for regulator-init-microvolt in > > linux. > > > Ohh, I forgot the kernel driver does not support this property. > > @Heiko, can we add this 'regulator-init-microvolt' without driver > support but adding document for > > it at dt-binding? In theory yes, but you would still need to get DT maintainers and Mark Brown (regulator maintainer) involved before that. Especially as this is a individual property you will need to have a good excuse why you're not implementing it in the kernel as well. And of course you will need to keep in mind that it might be in the kernel in the future. Heiko > > > Thanks, > > - Kever > > > > > Regards, > > Soeren > >> CC: Elaine Zhang > >> CC: Peter Robinson > >> Signed-off-by: Kever Yang > >> --- > >> > >> arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 1 + > >> arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 1 + > >> 9 files changed, 9 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >> index 77008dca45bc..fa241aeb11b0 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >> @@ -65,6 +65,7 @@ > >> regulator-name = "vdd_center"; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> regulator-always-on; > >> regulator-boot-on; > >> status = "okay"; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > >> index 92de83dd4dbc..4e45269fcdff 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > >> @@ -208,6 +208,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <430000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > >> index c133e8d64b2a..692f3154edc3 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts > >> @@ -100,6 +100,7 @@ > >> regulator-name = "vdd_log"; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> regulator-always-on; > >> regulator-boot-on; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > >> index 4944d78a0a1c..c2ac80d99301 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi > >> @@ -79,6 +79,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vsys_3v3>; > >> }; > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts b/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts > >> index 73be38a53796..c32abcc4ddc1 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-leez-p710.dts > >> @@ -101,6 +101,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc5v0_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts > >> index 0541dfce924d..9d674c51f025 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-orangepi.dts > >> @@ -164,6 +164,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > >> index 19f7732d728c..7d856ce1d156 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dts > >> @@ -129,6 +129,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc3v3_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> index e544deb61d28..8fbccbc8bf47 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts > >> @@ -174,6 +174,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1700000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc5v0_sys>; > >> }; > >> }; > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > >> index 1bc1579674e5..f8e2cb8c0624 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi > >> @@ -133,6 +133,7 @@ > >> regulator-boot-on; > >> regulator-min-microvolt = <800000>; > >> regulator-max-microvolt = <1400000>; > >> + regulator-init-microvolt = <950000>; > >> vin-supply = <&vcc_sys>; > >> }; > >> }; > > >