From: patchwork-bot+netdevbpf@kernel.org
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jeff@garzik.org, rdreier@cisco.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: ibm: emac: mal: fix potential system hang in mal_remove()
Date: Tue, 09 Jun 2026 00:40:10 +0000 [thread overview]
Message-ID: <178096561013.1730160.13610511675755814498.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260603230821.5619-1-rosenp@gmail.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 3 Jun 2026 16:08:21 -0700 you wrote:
> napi_disable() is not idempotent and calling it on an already-disabled
> or unenabled NAPI context will cause the kernel to spin indefinitely
> waiting for the NAPI_STATE_SCHED bit to clear.
>
> In mal_remove(), napi_disable() is called unconditionally. If no MACs were
> registered, NAPI was never enabled. Also, if they were registered but
> subsequently unregistered, NAPI was already disabled in
> mal_unregister_commac(). In either case, calling napi_disable() causes
> the kernel to hang upon module removal.
>
> [...]
Here is the summary with links:
- [net] net: ibm: emac: mal: fix potential system hang in mal_remove()
https://git.kernel.org/netdev/net-next/c/7c5d41f87f07
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-06-09 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 23:08 [PATCH net] net: ibm: emac: mal: fix potential system hang in mal_remove() Rosen Penev
2026-06-04 18:52 ` Jacob Keller
2026-06-04 23:03 ` Rosen Penev
2026-06-09 0:36 ` Jakub Kicinski
2026-06-09 1:13 ` Jacob Keller
2026-06-09 1:13 ` Jacob Keller
2026-06-09 1:51 ` Rosen Penev
2026-06-09 0:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178096561013.1730160.13610511675755814498.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdreier@cisco.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.