From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC3D275B03; Wed, 24 Jun 2026 02:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782267655; cv=none; b=OMEsKErEbA4m6+rG0j1dK2lvy+NC5YA3TVO+Epkz6eSlgvR0BEkdO3VkhQ/q0StDB7I+jTkR3aeiHrrfT6IVlM4PXVFx/DOzWiOHT4NUGk9eGZwfA67pNOw4zUAYGnk5H41rriuDYCATiWtoK16/QyPKSg2G0kGKLAiBVv+htmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782267655; c=relaxed/simple; bh=wwn6XUbKIvCiPSBA3TSc56WDWaioUhODoV6QTWPHC3o=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=rrBgvPlXq1wlFwzNdHU7jCT02nAySQm6gGS1TGo+9S1m+c3qFsbx8drZkd7episaS+NK4o8Q57Rof6Ap+gQXPx/dKSIku+II4vZxleFWdl74ZLS95zS40SEv6qTblnWedMsQHCMahJt3+K2OfSAW9bk4aXyIeWXyc0qzyrPffE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZtEszIvI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZtEszIvI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 655B31F000E9; Wed, 24 Jun 2026 02:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782267654; bh=YOAjeMHaG6nM10AE3YqdIXVgU/k5lU1/yhqshnZ5o3c=; h=Subject:From:Date:References:In-Reply-To:To:Cc; b=ZtEszIvI5scw2JK8+1RzhbKEg7cQCdXCOOLUPn3qtkvvmdGabYIsHFmJkcxZvOoEE eSJyeOt8C/MIYAozatA1KU/gXdGwRU07KLQu/k+t33k3QVju5PvIdcrFAoBAeSpWYg qxX/+YkjpAVEZkooYolNaSuqJOPA9E4nZqzOHf5P6+/Jn+bpSVKUipsn2NNt4kFMs2 M+4AoMmjos7O0+JDwVF3uzdrVfMPc9XTMUghdzhFHyu3NYD0Q6FEDdLdjI/xTUoYz3 jfcFn82yqFIK1CLbSZPJ9joglfyGLmnj3E2JCdZwP/cdTI81vmxe/wehZeIENeILUn dRXF/oQx4pJ4g== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id D0B6D393102A; Wed, 24 Jun 2026 02:20:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: au1000: move free_irq out of the close-time spinlocked section From: patchwork-bot+netdevbpf@kernel.org Message-Id: <178226764357.2513445.5024104235449335960.git-patchwork-notify@kernel.org> Date: Wed, 24 Jun 2026 02:20:43 +0000 References: <20260619151816.1144289-1-runyu.xiao@seu.edu.cn> In-Reply-To: <20260619151816.1144289-1-runyu.xiao@seu.edu.cn> To: Runyu Xiao Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 19 Jun 2026 23:18:16 +0800 you wrote: > au1000_close() calls free_irq() while aup->lock is still held with > spin_lock_irqsave(). free_irq() can sleep because it takes the IRQ > descriptor request mutex, so it does not belong inside the close-time > spinlocked section. > > This was found by our static analysis tool and then confirmed by manual > review of the in-tree au1000_close() .ndo_stop path. The reviewed path > keeps aup->lock held across the MAC reset, queue stop and > free_irq(dev->irq, dev). > > [...] Here is the summary with links: - [net] net: au1000: move free_irq out of the close-time spinlocked section https://git.kernel.org/netdev/net/c/f48763beab4e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html