Re: [PATCH v2] devtools: check wrong svg include in guides

[Thomas Monjalon <thomas@monjalon.net>]

01/11/2018 07:45, Arnon Warshavsky:
> Hi
> 
> >PS: the warning contains the regex. May it be improved?
> 
> How about passing an explicit warning message to the awk instead of the
> regex?

Yes it is a good idea.
I think it can be a separate patch. Would you like to send it please?

[..]
> +       if [ $? -ne 0 ] ; then
> +                ret=1
> +       fi
> +
> +       return $ret
>  }
> 
> I also noticed that there is a need to keep the return value from each
> check in case the first fails and the latter succeeds

No need of return code.
The error is detected if there is something printed to stdout.