All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Macher" <Stefan.Macher@web.de>
To: TakashiIwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: ALC658 SPDIF input patch
Date: Mon, 10 Jan 2005 16:08:46 +0100	[thread overview]
Message-ID: <1784107302@web.de> (raw)

> 
> At Sun, 9 Jan 2005 22:49:44 +0100,
> Stefan Macher wrote:
> > 
> > Hi,
> > 
> > I have made a patch to get SPDIF input working with the Realtek ALC658. 
> > Realtek has changed the meaning of the Pin47 function selection bit (MX7A bit 
> > 1 ) between ALC655 and ALC658.
> > 
> > ALC655: 0 -> external amplifier power down; 1 -> SPDIF IN
> > ALC658: 0 -> SPDIF IN; 1 -> external amplifier power down
> > 
> > 
> > Can please anybody include this into CVS.
> 
> The patch looks fine.
> 
> Could you provide a signed-off-by line and a brief summary of your
> patch to put as a changelog?  The best would be like:
> 
> 	Summary: Fix blah
> 
> 	The patch fixes the problem of the driver xxx...
> 
> 	Signed-off-by: Foo Bar <foo@bar.com>
> 
> 
> We need (prefer) to have this for each patch from contributors,
> especially for the changes to alsa-kernel tree, which will appear
> eventually in the Linux kernel tree.
> 
> 
> thanks,
> 
> Takashi
> 

Summary: Adapt SPDIF Input selection for Realtek ALC658

This fixes the SPDIF Input selection for ALC658 as Realtek has changed the meaning betweenALC655 and ALC658. 

Signed-off-by: Stefan Macher <Stefan.Macher@web.de>

-------------------------------------------------------------------------------------------------------------
 
 --- alsa-driver-1.0.8rc2/alsa-kernel/pci/ac97/ac97_patch.c      2005-01-04 
 12:01:01.000000000 +0100
 +++ alsa-driver-1.0.8rc2-alc658patch/alsa-kernel/pci/ac97/ac97_patch.c  
 2005-01-09 22:20:53.933529512 +0100
 @@ -1605,7 +1605,10 @@
 
         /* adjust default values */
         val = snd_ac97_read(ac97, 0x7a); /* misc control */
 -       val |= (1 << 1); /* spdif input pin */
 +       if(ac97->id == 0x414c4780) /* ALC658 */
 +               val &= ~(1 << 1); /* Pin 47 is spdif input pin */
 +       else /* ALC655 */
 +               val |= (1 << 1); /* Pin 47 is spdif input pin */
         val &= ~(1 << 12); /* vref enable */
         snd_ac97_write_cache(ac97, 0x7a, val);
         /* set default: spdif-in enabled,
 
__________________________________________________________
Mit WEB.DE FreePhone mit hoechster Qualitaet ab 0 Ct./Min.
weltweit telefonieren! http://freephone.web.de/?mc=021201



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

             reply	other threads:[~2005-01-10 15:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-10 15:08 Stefan Macher [this message]
2005-01-11 13:18 ` ALC658 SPDIF input patch Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2005-01-09 21:49 Stefan Macher
2005-01-10 12:02 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1784107302@web.de \
    --to=stefan.macher@web.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.