Re: [PATCH] examples/vhost: Fix vlan offload issue

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-12-12 12:15, Ouyang Changchun:
> The following commit break vm2vm hard mode test cases:
> commit db4014f2b65cb31bf209cadd5bcec778ca137fe2
> Author: Huawei Xie <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date:   Thu Nov 13 06:34:07 2014 +0800
>     examples/vhost: use factorized default Rx/Tx configuration
> 
> Investigation show that it needs enabling vlan offload since it is turn off by default,
> and Tx need it, especially when vm2vm is in hard mode.

I missed something here. Where VLAN offload is disabled by default?
Could you point the code, please?

> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -390,6 +390,9 @@ port_init(uint8_t port)
>  	txconf = &dev_info.default_txconf;
>  	rxconf->rx_drop_en = 1;
>  
> +	/* Enable vlan offload */
> +	txconf->txq_flags &= ~ETH_TXQ_FLAGS_NOVLANOFFL;
> +
>  	/*
>  	 * Zero copy defers queue RX/TX start to the time when guest
>  	 * finishes its startup and packet buffers from that guest are
>