From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [BUG] sandbox: './u-boot -l ' fails
Date: Tue, 29 Sep 2020 15:05:29 +0200 [thread overview]
Message-ID: <178659.1601384729@gemini.denx.de> (raw)
In-Reply-To: <0CBB3DF2-632B-4DAB-BD39-E2CE9F5AF513@gmx.de>
Dear Heinrich,
In message <0CBB3DF2-632B-4DAB-BD39-E2CE9F5AF513@gmx.de> you wrote:
>
> >We should not invent any new names when there are existing good
> >alterntives.
> >
> >Why not use getchar()?
...
> please, have a look at http://patchwork.ozlabs.org/project/uboot/patch> /20200928234514.124945-1-xypron.glpk at gmx.de/
>
> Is such a #define the way to go or should we globally rename getc?
I don't think this is a good idea; I would recommend to keep the
getc() as used so far in normal U-Boot, and only "translate" it into
getchar() for the sandbox environment.
Especially messing with include/_exports.h is critical, as this is
used for standalone applications, which are the only allowed
exception from GPL code, so we have to assume there is some amount
of binary-only code in the field, and we should be careful not to
break this without need. Changes here may break compatibility.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Well I don't see why I have to make one man miserable when I can
make so many men happy." - Ellyn Mustard, about marriage
prev parent reply other threads:[~2020-09-29 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 19:48 [BUG] sandbox: './u-boot -l ' fails Heinrich Schuchardt
2020-09-28 4:24 ` Simon Glass
2020-09-28 4:46 ` Heinrich Schuchardt
2020-09-28 11:31 ` Heinrich Schuchardt
2020-09-28 13:22 ` Simon Glass
2020-09-28 13:30 ` Heinrich Schuchardt
2020-09-28 13:42 ` Simon Glass
2020-09-28 21:23 ` Heinrich Schuchardt
2020-09-28 22:19 ` Simon Glass
2020-09-28 23:59 ` Heinrich Schuchardt
2020-09-29 1:21 ` Heinrich Schuchardt
2020-09-29 11:12 ` Wolfgang Denk
2020-09-29 11:47 ` Heinrich Schuchardt
2020-09-29 13:05 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178659.1601384729@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.