From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A3F463B6D; Thu, 13 Aug 2026 11:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619789; cv=none; b=LxqIY0N5jQssuYoRNj3fRpuntKeNNlOYoZdVb3nz6xP3X8fGMGLUFfdlDEFLUPQ52DKDRm2YcT7QJMdvEm1bx3Au9HgwEKVObGSnmWRiCexwi4UYl9Kn295YiIg7PvEka5ojFg0bmLEJoAXErue+uziswnub62ZB4ZlKQgIEoVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619789; c=relaxed/simple; bh=O2BRUHfvLonjec6OJP/rlkRbwUDiK0g2NKF98RoqLYs=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=ZLuyiyGeNnFLnVUA0EtBY7Qib+XlyTwqcNLDQuB+4VOE9Hn9OkslVM992Q75VvZmR8XF91wiODYUNbnKZwWqQy8opgfWKqt27TPSA4+suTFzpLCd8IhHV1oHuNERJROhngR1lSXoUWS9NhP4oWgmjm03P2jjUBCYKmDCTzmjxTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=CKWoryCE; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=EsNT3o3n; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="CKWoryCE"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="EsNT3o3n" Date: Thu, 13 Aug 2026 11:16:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1786619783; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H1NSR7AvA0NwvazJMmob8gBEyxwy+aLpPdHE7h8MEbc=; b=CKWoryCE8wfnxK8Grrjdbh2Z1luEwSV5mkd9Nd2o9LKpEvzZYZM5iUKJra9KRIAPTtm63z JEjxXC58IizgA1Nk4ZHeqgFjrx4BtsWW3fbq7QhmkU99RlSLNj0FaCTEKM3/0+TUteQ5dU Yjm6dJf41u2YVk4+ils4NYeKste6Zyp1t2ROc0qYwc3dvXiDFNMBynfeUCy8AcSNDpkUbN fTckM6O0w6ybieOd7HStyz3U8cIT8JTASZleZtrJ6bOHG8S1ZuWOcolpvZODgTuMjd9vh4 RsEys0gGXAO7OWmc+OGV6kTN6o0neaBX+GMKB06FN3LG4kwXLwGL5qmXTNjezg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1786619783; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H1NSR7AvA0NwvazJMmob8gBEyxwy+aLpPdHE7h8MEbc=; b=EsNT3o3nzlYOHMXY5909Sz5oh/HwCSfB9UZVhui01tybhVowi5+ZZFc/QcFqMoLQOcy/Vf +Z7SqjDgCnxVF5DQ== From: "tip-bot2 for Josh Poimboeuf" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] objtool/klp: Fix line numbers in Module.symvers parse errors Cc: Joe Lawrence , Song Liu , Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <133e16bb0c7cb916f10bbfb017eba525449ad1d6.1786138493.git.jpoimboe@kernel.org> References: <133e16bb0c7cb916f10bbfb017eba525449ad1d6.1786138493.git.jpoimboe@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <178661978201.442315.138489456877962108.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the objtool/core branch of tip: Commit-ID: 51c1de13486315ad46a74b40ec17124916a08277 Gitweb: https://git.kernel.org/tip/51c1de13486315ad46a74b40ec17124916a= 08277 Author: Josh Poimboeuf AuthorDate: Fri, 07 Aug 2026 14:37:54 -07:00 Committer: Josh Poimboeuf CommitterDate: Tue, 11 Aug 2026 16:10:58 -07:00 objtool/klp: Fix line numbers in Module.symvers parse errors read_exports() reports the offending line number when it fails to parse Module.symvers. The counter is initialized to 1 but never incremented, so every error blames line 1 regardless of where the bad line is. Acked-by: Joe Lawrence Acked-by: Song Liu Link: https://patch.msgid.link/133e16bb0c7cb916f10bbfb017eba525449ad1d6.17861= 38493.git.jpoimboe@kernel.org Signed-off-by: Josh Poimboeuf --- tools/objtool/klp-diff.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c index 1f05646..cdc63ab 100644 --- a/tools/objtool/klp-diff.c +++ b/tools/objtool/klp-diff.c @@ -118,7 +118,7 @@ static int read_exports(void) { const char *symvers =3D "Module.symvers"; char line[1024], *path =3D NULL; - unsigned int line_num =3D 1; + unsigned int line_num =3D 0; FILE *file; =20 file =3D fopen(symvers, "r"); @@ -140,6 +140,8 @@ static int read_exports(void) char *sym, *mod, *type, *namespace; struct export *export; =20 + line_num++; + sym =3D strchr(line, '\t'); if (!sym) { ERROR("malformed Module.symvers (sym) at line %d", line_num);