From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system
Date: Wed, 22 Jul 2020 14:45:54 +0200 [thread overview]
Message-ID: <1786897.AIzr81cTuv@thomas> (raw)
In-Reply-To: <20200721153950.748927-1-bruce.richardson@intel.com>
21/07/2020 17:39, Bruce Richardson:
> When building the DPDK guide documents, the DPDK version information was
> pulled using "make showversion", which meant there was a dependency on
> the DPDK make-based build system. Change this to just read the data from
> the VERSION file in the root directory.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> NOTE: When make build system is completed removed, we can change the
> relative path to the VERSION file i.e. "../../", to instead pull the
> path from "MESON_SOURCE_ROOT" in the environment, which should be more
> robust.
Yes it would be a bit better.
If we merge this patch in 20.08, we'll forget about this improvement :)
I suggest waiting 20.11 to merge the definitive improvement.
next prev parent reply other threads:[~2020-07-22 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 15:39 [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system Bruce Richardson
2020-07-21 15:42 ` Bruce Richardson
2020-07-22 12:45 ` Thomas Monjalon [this message]
2020-07-22 12:59 ` Bruce Richardson
2020-08-20 15:54 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1786897.AIzr81cTuv@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.