From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org, eric.dumazet@gmail.com,
xietangxin@h-partners.com, stable@vger.kernel.org
Subject: Re: [PATCH v3 net] vlan: fix skb_under_panic and races when toggling HW VLAN offload
Date: Thu, 20 Aug 2026 20:30:29 +0000 [thread overview]
Message-ID: <178725782988.470503.15788449935898012814.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260811085246.2267779-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 11 Aug 2026 08:52:46 +0000 you wrote:
> Toggling hardware VLAN TX offload (NETIF_F_HW_VLAN_CTAG_TX or
> NETIF_F_HW_VLAN_STAG_TX) on a lower device invokes vlan_transfer_features(),
> which dynamically changed vlandev->hard_header_len.
>
> This causes two issues:
> 1. Lockless TX paths (e.g. packet_snd in af_packet.c, ip6_finish_output2)
> read dev->hard_header_len without holding RTNL lock. Mutating
> hard_header_len dynamically under RTNL creates a data race where upper
> layers reserve insufficient headroom based on a stale hard_header_len,
> resulting in skb_under_panic when vlan_dev_hard_header() is called.
> 2. In addition, vlan_transfer_features() updated hard_header_len without
> updating header_ops, causing a mismatch between allocated headroom
> and header creation.
>
> [...]
Here is the summary with links:
- [v3,net] vlan: fix skb_under_panic and races when toggling HW VLAN offload
https://git.kernel.org/netdev/net/c/447cbe95ebb9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-08-20 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 8:52 [PATCH v3 net] vlan: fix skb_under_panic and races when toggling HW VLAN offload Eric Dumazet
2026-08-13 8:49 ` Paolo Abeni
2026-08-19 7:49 ` xietangxin
2026-08-19 8:07 ` Eric Dumazet
2026-08-19 8:50 ` Paolo Abeni
2026-08-20 20:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178725782988.470503.15788449935898012814.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xietangxin@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.