All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuyf26 <Chuyf26@linux.alibaba.com>
To: horms@kernel.org
Cc: xeb@mail.ru, netdev@vger.kernel.org, running910@gmail.com
Subject: Re: [PATCH] pptp: reject payloads shorter than the PPP protocol field
Date: Fri, 21 Aug 2026 17:42:33 +0800	[thread overview]
Message-ID: <178730535313.476144.475903977991245292@linux.alibaba.com> (raw)
In-Reply-To: <20260821090713.GE265046@horms.kernel.org>

Simon,

thanks for the review. Your concern is valid: payload_len is only a
lower bound since the skb is never trimmed to headersize + payload_len,
so bounding the new checks by the peer-advertised value instead of the
bytes actually present (skb->len - headersize) would indeed change the
receive behaviour for a peer that under-reports payload_len, as you
described.

Given that, and that this duplicates the earlier pptp patch from
Zhixing Chen which carries the same concern, I am withdrawing this
patch rather than posting a v2.

Sorry for the noise.

Chuyf26

  reply	other threads:[~2026-08-21  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 16:21 [PATCH] pptp: reject payloads shorter than the PPP protocol field Chuyf26
2026-08-21  9:07 ` Simon Horman
2026-08-21  9:42   ` Chuyf26 [this message]
2026-08-21  9:26 ` Simon Horman
2026-08-21  9:42   ` Chuyf26

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178730535313.476144.475903977991245292@linux.alibaba.com \
    --to=chuyf26@linux.alibaba.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=running910@gmail.com \
    --cc=xeb@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.