All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Nicholas Pratte <npratte@iol.unh.edu>
Cc: luca.vizzarro@arm.com, jspewock@iol.unh.edu,
	paul.szczepanek@arm.com, Honnappa.Nagarahalli@arm.com,
	yoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech,
	probb@iol.unh.edu, bruce.richardson@intel.com, dev@dpdk.org
Subject: Re: [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively
Date: Thu, 20 Jun 2024 03:55:55 +0200	[thread overview]
Message-ID: <1787400.8DbOzPnMyl@thomas> (raw)
In-Reply-To: <20240610152048.23617-4-npratte@iol.unh.edu>

10/06/2024 17:20, Nicholas Pratte:
>       You may specify the optional hugepage configuration in the DTS config file.
>       If you do, DTS will take care of configuring hugepages,
> -     overwriting your current SUT hugepage configuration.
> +     overwriting your current SUT hugepage configuration. Configuration of hugepages via DTS
> +     allows only for allocation of 2MB hugepages, as doing so prevents accidental/over
> +     allocation of hugepage sizes not recommended during runtime due to
> +     contiguous memory space requirements. Thus, if you require hugepage
> +     sizes not equal to 2MB, then this configuration must be done outside of the DTS framework.

Lines must be broken logically, example: after a dot or comma.

>  
>     * System under test configuration
>  
> @@ -453,11 +457,11 @@ _`Build target`
>                          **Example**: ``ccache``
>     ==================== =================================================================
>  
> -_`hugepages`
> -   *mapping* – hugepages described as:
> +_`hugepages_2mb`
> +   *mapping* – hugepages_2mb described as:
>  
>     ==================== ================================================================
> -   ``amount``           *integer* – The amount of hugepages to configure.
> +   ``number_of``        *integer* – The number of 2MB hugepages to configure.

The rename to "number_of" belongs to the next commit.

>  
>                          Hugepage size will be the system default.
>     ``force_first_numa`` (*optional*, defaults to ``false``) – If ``true``, it forces the
> @@ -570,7 +574,7 @@ involved in the testing. These can be defined with the following mappings:
>     |                       |                                                                                       |
>     |                       | The number of the memory channels to use.                                             |
>     +-----------------------+---------------------------------------------------------------------------------------+
> -   | ``hugepages``         | (*optional*) See `hugepages`_. If unset, hugepages won't be configured                |
> +   | ``hugepages_2mb``     | (*optional*) See `hugepages`_. If unset, 2MB hugepages won't be configured            |

The link needs to be changed to hugepages_2mb here.
There is an error in CI while generating doc.




  parent reply	other threads:[~2024-06-20  1:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 15:20 [PATCH v9 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-06-10 15:20 ` [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-06-10 15:26   ` Juraj Linkeš
2024-06-17 15:08   ` Luca Vizzarro
2024-06-20  1:55   ` Thomas Monjalon [this message]
2024-06-10 15:20 ` [PATCH v9 2/2] dts: Change hugepage 'amount' to a different term Nicholas Pratte
2024-06-10 15:26   ` Juraj Linkeš
2024-06-17 15:08   ` Luca Vizzarro
2024-06-20  2:06 ` [PATCH v9 0/2] Methodology change for hugepage configuration Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2024-04-30 18:45 [PATCH v5 " Nicholas Pratte
2024-06-07 14:31 ` [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-06-07 14:59 ` [PATCH v9 0/2] Methodology change for hugepage configuration Nicholas Pratte
2024-06-07 14:59   ` [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively Nicholas Pratte
2024-06-10  7:38     ` Juraj Linkeš
2024-06-17 14:59     ` Luca Vizzarro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1787400.8DbOzPnMyl@thomas \
    --to=thomas@monjalon.net \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jspewock@iol.unh.edu \
    --cc=juraj.linkes@pantheon.tech \
    --cc=luca.vizzarro@arm.com \
    --cc=npratte@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.