From: patchwork-bot+netdevbpf@kernel.org
To: Victor Nogueira <victor@mojatatu.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jhs@mojatatu.com, jiri@resnulli.us,
horms@kernel.org, bestswngs@gmail.com, vega@nebusec.ai,
netdev@vger.kernel.org
Subject: Re: [PATCH net RESEND] net/sched: sch_teql: restore skb->dev on the slave failure path
Date: Tue, 25 Aug 2026 13:30:13 +0000 [thread overview]
Message-ID: <178766461348.3460835.4622970017775216040.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260824115928.4099988-1-victor@mojatatu.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 24 Aug 2026 08:59:28 -0300 you wrote:
> teql_master_xmit() sets skb->dev = slave before calling the slave's
> ndo_start_xmit(), but never restores it when that transmit fails. The
> skb then walks on to the next slave still pointing at the previous one.
>
> If a later slave has no resolved neighbour, teql_resolve() hands the skb
> to neigh_event_send(), which queues it on that neighbour's arp_queue
> with the stale skb->dev. skb->dev holds no reference, so deleting the
> previous slave frees the net_device while the skb is still queued.
> Whatever runs next on that skb - arp_error_report() on timeout, or
> neigh_direct_output() -> dev_queue_xmit() once the neighbour resolves -
> causes a UAF like the one below:
>
> [...]
Here is the summary with links:
- [net,RESEND] net/sched: sch_teql: restore skb->dev on the slave failure path
https://git.kernel.org/netdev/net/c/dc4b95b8fee9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-08-25 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:59 [PATCH net RESEND] net/sched: sch_teql: restore skb->dev on the slave failure path Victor Nogueira
2026-08-25 13:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178766461348.3460835.4622970017775216040.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bestswngs@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vega@nebusec.ai \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.