All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Yuan Chen <chenyuan_fl@163.com>
Cc: bpf@vger.kernel.org, qmo@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
	memxor@gmail.com, andrii.nakryiko@gmail.com, chenyuan@kylinos.cn
Subject: Re: [PATCH bpf-next v6 1/2] bpftool: fix spurious batch file read error
Date: Fri, 28 Aug 2026 00:10:08 +0000	[thread overview]
Message-ID: <178787580816.1904688.16155648098881499182.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260824092657.1789956-2-chenyuan_fl@163.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Mon, 24 Aug 2026 17:26:56 +0800 you wrote:
> do_batch() checks errno after the read loop to detect read failures,
> but fgets() does not clear errno on success, so a stale errno left by
> a previously executed command (e.g. map dump's EBADF from a double
> close) makes bpftool report a batch file read failure and exit with an
> error even though every command succeeded.
> 
> Clear errno before each fgets() call, so the post-loop check only
> sees the outcome of the last read: zero on success or EOF, E2BIG for
> an overlong line, and a genuine errno when fgets() fails.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v6,1/2] bpftool: fix spurious batch file read error
    https://git.kernel.org/bpf/bpf-next/c/713c02b59e21

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



  parent reply	other threads:[~2026-08-28  0:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 14:22 [PATCH bpf-next v5 0/3] bpftool: fix batch file handling issues chenyuan_fl
2026-08-10 14:22 ` [PATCH bpf-next v5 1/3] bpftool: fix double close in map dump chenyuan_fl
2026-08-10 14:22 ` [PATCH bpf-next v5 2/3] bpftool: fix spurious batch file read error chenyuan_fl
2026-08-13 21:56   ` Andrii Nakryiko
2026-08-10 14:22 ` [PATCH bpf-next v5 3/3] bpftool: Fix bypass of the batch line length check by comments chenyuan_fl
2026-08-10 14:44   ` sashiko-bot
2026-08-13 22:00   ` Andrii Nakryiko
2026-08-24  9:26 ` [PATCH bpf-next v6 0/2] bpftool: fix batch file handling issues Yuan Chen
2026-08-24  9:26 ` [PATCH bpf-next v6 1/2] bpftool: fix spurious batch file read error Yuan Chen
2026-08-24 10:02   ` bot+bpf-ci
2026-08-28  0:10   ` patchwork-bot+netdevbpf [this message]
2026-08-24  9:26 ` [PATCH bpf-next v6 2/2] bpftool: Fix bypass of the batch line length check by comments Yuan Chen
2026-08-28  0:10   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178787580816.1904688.16155648098881499182.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chenyuan@kylinos.cn \
    --cc=chenyuan_fl@163.com \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=memxor@gmail.com \
    --cc=qmo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.