From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10 Date: Fri, 08 Nov 2019 16:08:50 +0100 Message-ID: <17879396.dXe580Ps6o@diego> References: <1569486289-152061-1-git-send-email-hjc@rock-chips.com> <1569486289-152061-2-git-send-email-hjc@rock-chips.com> <20191009145008.GB16989@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CD0F6F9C5 for ; Fri, 8 Nov 2019 15:09:01 +0000 (UTC) In-Reply-To: <20191009145008.GB16989@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Maxime Ripard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLCBTYW5keSwKCkFtIE1pdHR3b2NoLCA5LiBPa3RvYmVyIDIwMTksIDE2OjUwOjA4 IENFVCBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gT24gVGh1LCBTZXAgMjYsIDIwMTkgYXQgMDQ6 MjQ6NDdQTSArMDgwMCwgU2FuZHkgSHVhbmcgd3JvdGU6Cj4gPiBUaGVzZSBuZXcgZm9ybWF0IGlz IHN1cHBvcnRlZCBieSBzb21lIHJvY2tjaGlwIHNvY3M6Cj4gPiAKPiA+IERSTV9GT1JNQVRfTlYx Ml8xMC9EUk1fRk9STUFUX05WMjFfMTAKPiA+IERSTV9GT1JNQVRfTlYxNl8xMC9EUk1fRk9STUFU X05WNjFfMTAKPiA+IERSTV9GT1JNQVRfTlYyNF8xMC9EUk1fRk9STUFUX05WNDJfMTAKPiA+IAo+ ID4gU2lnbmVkLW9mZi1ieTogU2FuZHkgSHVhbmcgPGhqY0Byb2NrLWNoaXBzLmNvbT4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMgIHwgMTggKysrKysrKysrKysrKysr KysrCj4gPiAgaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmggfCAxNCArKysrKysrKysrKysr Kwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f Zm91cmNjLmMKPiA+IGluZGV4IGM2MzAwNjQuLmNjZDc4YTMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zv dXJjYy5jCj4gPiBAQCAtMjYxLDYgKzI2MSwyNCBAQCBjb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9p bmZvICpfX2RybV9mb3JtYXRfaW5mbyh1MzIgZm9ybWF0KQo+ID4gIAkJeyAuZm9ybWF0ID0gRFJN X0ZPUk1BVF9QMDE2LAkJLmRlcHRoID0gMCwgIC5udW1fcGxhbmVzID0gMiwKPiA+ICAJCSAgLmNo YXJfcGVyX2Jsb2NrID0geyAyLCA0LCAwIH0sIC5ibG9ja193ID0geyAxLCAwLCAwIH0sIC5ibG9j a19oID0geyAxLCAwLCAwIH0sCj4gPiAgCQkgIC5oc3ViID0gMiwgLnZzdWIgPSAyLCAuaXNfeXV2 ID0gdHJ1ZX0sCj4gPiArCQl7IC5mb3JtYXQgPSBEUk1fRk9STUFUX05WMTJfMTAsCQkuZGVwdGgg PSAwLCAgLm51bV9wbGFuZXMgPSAyLAo+ID4gKwkJICAuY2hhcl9wZXJfYmxvY2sgPSB7IDUsIDEw LCAwIH0sIC5ibG9ja193ID0geyA0LCA0LCAwIH0sIC5ibG9ja19oID0geyA0LCA0LCAwIH0sCj4g PiArCQkgIC5oc3ViID0gMiwgLnZzdWIgPSAyLCAuaXNfeXV2ID0gdHJ1ZX0sCj4gPiArCQl7IC5m b3JtYXQgPSBEUk1fRk9STUFUX05WMjFfMTAsCQkuZGVwdGggPSAwLCAgLm51bV9wbGFuZXMgPSAy LAo+ID4gKwkJICAuY2hhcl9wZXJfYmxvY2sgPSB7IDUsIDEwLCAwIH0sIC5ibG9ja193ID0geyA0 LCA0LCAwIH0sIC5ibG9ja19oID0geyA0LCA0LCAwIH0sCj4gPiArCQkgIC5oc3ViID0gMiwgLnZz dWIgPSAyLCAuaXNfeXV2ID0gdHJ1ZX0sCj4gPiArCQl7IC5mb3JtYXQgPSBEUk1fRk9STUFUX05W MTZfMTAsCQkuZGVwdGggPSAwLCAgLm51bV9wbGFuZXMgPSAyLAo+ID4gKwkJICAuY2hhcl9wZXJf YmxvY2sgPSB7IDUsIDEwLCAwIH0sIC5ibG9ja193ID0geyA0LCA0LCAwIH0sIC5ibG9ja19oID0g eyA0LCA0LCAwIH0sCj4gPiArCQkgIC5oc3ViID0gMiwgLnZzdWIgPSAxLCAuaXNfeXV2ID0gdHJ1 ZX0sCj4gPiArCQl7IC5mb3JtYXQgPSBEUk1fRk9STUFUX05WNjFfMTAsCQkuZGVwdGggPSAwLCAg Lm51bV9wbGFuZXMgPSAyLAo+ID4gKwkJICAuY2hhcl9wZXJfYmxvY2sgPSB7IDUsIDEwLCAwIH0s IC5ibG9ja193ID0geyA0LCA0LCAwIH0sIC5ibG9ja19oID0geyA0LCA0LCAwIH0sCj4gPiArCQkg IC5oc3ViID0gMiwgLnZzdWIgPSAxLCAuaXNfeXV2ID0gdHJ1ZX0sCj4gPiArCQl7IC5mb3JtYXQg PSBEUk1fRk9STUFUX05WMjRfMTAsCQkuZGVwdGggPSAwLCAgLm51bV9wbGFuZXMgPSAyLAo+ID4g KwkJICAuY2hhcl9wZXJfYmxvY2sgPSB7IDUsIDEwLCAwIH0sIC5ibG9ja193ID0geyA0LCA0LCAw IH0sIC5ibG9ja19oID0geyA0LCA0LCAwIH0sCj4gPiArCQkgIC5oc3ViID0gMSwgLnZzdWIgPSAx LCAuaXNfeXV2ID0gdHJ1ZX0sCj4gPiArCQl7IC5mb3JtYXQgPSBEUk1fRk9STUFUX05WNDJfMTAs CQkuZGVwdGggPSAwLCAgLm51bV9wbGFuZXMgPSAyLAo+ID4gKwkJICAuY2hhcl9wZXJfYmxvY2sg PSB7IDUsIDEwLCAwIH0sIC5ibG9ja193ID0geyA0LCA0LCAwIH0sIC5ibG9ja19oID0geyA0LCA0 LCAwIH0sCj4gPiArCQkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLCAuaXNfeXV2ID0gdHJ1ZX0sCj4g PiAgCQl7IC5mb3JtYXQgPSBEUk1fRk9STUFUX1AyMTAsCQkuZGVwdGggPSAwLAo+ID4gIAkJICAu bnVtX3BsYW5lcyA9IDIsIC5jaGFyX3Blcl9ibG9jayA9IHsgMiwgNCwgMCB9LAo+ID4gIAkJICAu YmxvY2tfdyA9IHsgMSwgMCwgMCB9LCAuYmxvY2tfaCA9IHsgMSwgMCwgMCB9LCAuaHN1YiA9IDIs Cj4gCj4gWXVwIHRoaXMgaXMgd2hhdCBJIGhhZCBpbiBtaW5kIHdpdGggdXNpbmcgdGhlIGJsb2Nr IHN0dWZmIHRvIGRlc2NyaWJlIHlvdXIKPiBuZXcgMTBiaXQgeXV2IGZvcm1hdHMuIFRoYW5rcyBm b3IgcmVzcGluaW5nLgo+IAo+IE9uY2Ugd2UndmUgbmFpbGVkIHRoZSBleGFjdCBiaXQgZGVzY3Jp cHRpb24gb2YgdGhlIGZvcm1hdCBwcmVjaXNlbHkgdGhpcwo+IGNhbiBiZSBtZXJnZWQgaW1vLgoK SSBqdXN0IHNhdyB0aGlzIHNlcmllcyBzdGlsbCBzaXR0aW5nIGluIG15IGluYm94LCBzbyB3YXMg d29uZGVyaW5nIGFib3V0IHRoZQoib25jZSB3ZSd2ZSBuYWlsZWQgdGhlIGV4YWN0IGJpdCBkZXNj cmlwdGlvbi4uLiIgYW5kIHdoYXQgaXMgbWlzc2luZyBmb3IgdGhhdC4KClRoYW5rcwpIZWlrbwoK Cj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmggYi9pbmNsdWRl L3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+ID4gaW5kZXggM2ZlZWFhMy4uMDhlMjIyMSAxMDA2NDQK PiA+IC0tLSBhL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gPiArKysgYi9pbmNsdWRl L3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+ID4gQEAgLTIzOCw2ICsyMzgsMjAgQEAgZXh0ZXJuICJD IiB7Cj4gPiAgI2RlZmluZSBEUk1fRk9STUFUX05WNDIJCWZvdXJjY19jb2RlKCdOJywgJ1YnLCAn NCcsICcyJykgLyogbm9uLXN1YnNhbXBsZWQgQ2I6Q3IgcGxhbmUgKi8KPiA+ICAKPiA+ICAvKgo+ ID4gKyAqIDIgcGxhbmUgWUNiQ3IKPiA+ICsgKiBpbmRleCAwID0gWSBwbGFuZSwgWTM6WTI6WTE6 WTAgMTA6MTA6MTA6MTAKPiA+ICsgKiBpbmRleCAxID0gQ2I6Q3IgcGxhbmUsIENiMzpDcjM6Q2Iy OkNyMjpDYjE6Q3IxOkNiMDpDcjAgMTA6MTA6MTA6MTA6MTA6MTA6MTA6MTAKPiA+ICsgKiBvcgo+ ID4gKyAqIGluZGV4IDEgPSBDcjpDYiBwbGFuZSwgQ3IzOkNiMzpDcjI6Q2IyOkNyMTpDYjE6Q3Iw OkNiMCAxMDoxMDoxMDoxMDoxMDoxMDoxMDoxMAo+ID4gKyAqLwo+ID4gKyNkZWZpbmUgRFJNX0ZP Uk1BVF9OVjEyXzEwCWZvdXJjY19jb2RlKCdOJywgJ0EnLCAnMScsICcyJykgLyogMngyIHN1YnNh bXBsZWQgQ3I6Q2IgcGxhbmUgKi8KPiA+ICsjZGVmaW5lIERSTV9GT1JNQVRfTlYyMV8xMAlmb3Vy Y2NfY29kZSgnTicsICdBJywgJzInLCAnMScpIC8qIDJ4MiBzdWJzYW1wbGVkIENiOkNyIHBsYW5l ICovCj4gPiArI2RlZmluZSBEUk1fRk9STUFUX05WMTZfMTAJZm91cmNjX2NvZGUoJ04nLCAnQScs ICcxJywgJzYnKSAvKiAyeDEgc3Vic2FtcGxlZCBDcjpDYiBwbGFuZSAqLwo+ID4gKyNkZWZpbmUg RFJNX0ZPUk1BVF9OVjYxXzEwCWZvdXJjY19jb2RlKCdOJywgJ0EnLCAnNicsICcxJykgLyogMngx IHN1YnNhbXBsZWQgQ2I6Q3IgcGxhbmUgKi8KPiA+ICsjZGVmaW5lIERSTV9GT1JNQVRfTlYyNF8x MAlmb3VyY2NfY29kZSgnTicsICdBJywgJzInLCAnNCcpIC8qIG5vbi1zdWJzYW1wbGVkIENyOkNi IHBsYW5lICovCj4gPiArI2RlZmluZSBEUk1fRk9STUFUX05WNDJfMTAJZm91cmNjX2NvZGUoJ04n LCAnQScsICc0JywgJzInKSAvKiBub24tc3Vic2FtcGxlZCBDYjpDciBwbGFuZSAqLwo+ID4gKwo+ ID4gKy8qCj4gPiAgICogMiBwbGFuZSBZQ2JDciBNU0IgYWxpZ25lZAo+ID4gICAqIGluZGV4IDAg PSBZIHBsYW5lLCBbMTU6MF0gWTp4IFsxMDo2XSBsaXR0bGUgZW5kaWFuCj4gPiAgICogaW5kZXgg MSA9IENyOkNiIHBsYW5lLCBbMzE6MF0gQ3I6eDpDYjp4IFsxMDo2OjEwOjZdIGxpdHRsZSBlbmRp YW4KPiAKPiAKCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBD7FA372C for ; Fri, 8 Nov 2019 15:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75107215EA for ; Fri, 8 Nov 2019 15:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbfKHPJM (ORCPT ); Fri, 8 Nov 2019 10:09:12 -0500 Received: from gloria.sntech.de ([185.11.138.130]:60112 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbfKHPJM (ORCPT ); Fri, 8 Nov 2019 10:09:12 -0500 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT5sY-0001pZ-Ns; Fri, 08 Nov 2019 16:08:50 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Vetter Cc: Sandy Huang , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10 Date: Fri, 08 Nov 2019 16:08:50 +0100 Message-ID: <17879396.dXe580Ps6o@diego> In-Reply-To: <20191009145008.GB16989@phenom.ffwll.local> References: <1569486289-152061-1-git-send-email-hjc@rock-chips.com> <1569486289-152061-2-git-send-email-hjc@rock-chips.com> <20191009145008.GB16989@phenom.ffwll.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Sandy, Am Mittwoch, 9. Oktober 2019, 16:50:08 CET schrieb Daniel Vetter: > On Thu, Sep 26, 2019 at 04:24:47PM +0800, Sandy Huang wrote: > > These new format is supported by some rockchip socs: > > > > DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10 > > DRM_FORMAT_NV16_10/DRM_FORMAT_NV61_10 > > DRM_FORMAT_NV24_10/DRM_FORMAT_NV42_10 > > > > Signed-off-by: Sandy Huang > > --- > > drivers/gpu/drm/drm_fourcc.c | 18 ++++++++++++++++++ > > include/uapi/drm/drm_fourcc.h | 14 ++++++++++++++ > > 2 files changed, 32 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > > index c630064..ccd78a3 100644 > > --- a/drivers/gpu/drm/drm_fourcc.c > > +++ b/drivers/gpu/drm/drm_fourcc.c > > @@ -261,6 +261,24 @@ const struct drm_format_info *__drm_format_info(u32 format) > > { .format = DRM_FORMAT_P016, .depth = 0, .num_planes = 2, > > .char_per_block = { 2, 4, 0 }, .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, > > .hsub = 2, .vsub = 2, .is_yuv = true}, > > + { .format = DRM_FORMAT_NV12_10, .depth = 0, .num_planes = 2, > > + .char_per_block = { 5, 10, 0 }, .block_w = { 4, 4, 0 }, .block_h = { 4, 4, 0 }, > > + .hsub = 2, .vsub = 2, .is_yuv = true}, > > + { .format = DRM_FORMAT_NV21_10, .depth = 0, .num_planes = 2, > > + .char_per_block = { 5, 10, 0 }, .block_w = { 4, 4, 0 }, .block_h = { 4, 4, 0 }, > > + .hsub = 2, .vsub = 2, .is_yuv = true}, > > + { .format = DRM_FORMAT_NV16_10, .depth = 0, .num_planes = 2, > > + .char_per_block = { 5, 10, 0 }, .block_w = { 4, 4, 0 }, .block_h = { 4, 4, 0 }, > > + .hsub = 2, .vsub = 1, .is_yuv = true}, > > + { .format = DRM_FORMAT_NV61_10, .depth = 0, .num_planes = 2, > > + .char_per_block = { 5, 10, 0 }, .block_w = { 4, 4, 0 }, .block_h = { 4, 4, 0 }, > > + .hsub = 2, .vsub = 1, .is_yuv = true}, > > + { .format = DRM_FORMAT_NV24_10, .depth = 0, .num_planes = 2, > > + .char_per_block = { 5, 10, 0 }, .block_w = { 4, 4, 0 }, .block_h = { 4, 4, 0 }, > > + .hsub = 1, .vsub = 1, .is_yuv = true}, > > + { .format = DRM_FORMAT_NV42_10, .depth = 0, .num_planes = 2, > > + .char_per_block = { 5, 10, 0 }, .block_w = { 4, 4, 0 }, .block_h = { 4, 4, 0 }, > > + .hsub = 1, .vsub = 1, .is_yuv = true}, > > { .format = DRM_FORMAT_P210, .depth = 0, > > .num_planes = 2, .char_per_block = { 2, 4, 0 }, > > .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, .hsub = 2, > > Yup this is what I had in mind with using the block stuff to describe your > new 10bit yuv formats. Thanks for respining. > > Once we've nailed the exact bit description of the format precisely this > can be merged imo. I just saw this series still sitting in my inbox, so was wondering about the "once we've nailed the exact bit description..." and what is missing for that. Thanks Heiko > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > > index 3feeaa3..08e2221 100644 > > --- a/include/uapi/drm/drm_fourcc.h > > +++ b/include/uapi/drm/drm_fourcc.h > > @@ -238,6 +238,20 @@ extern "C" { > > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > > > > /* > > + * 2 plane YCbCr > > + * index 0 = Y plane, Y3:Y2:Y1:Y0 10:10:10:10 > > + * index 1 = Cb:Cr plane, Cb3:Cr3:Cb2:Cr2:Cb1:Cr1:Cb0:Cr0 10:10:10:10:10:10:10:10 > > + * or > > + * index 1 = Cr:Cb plane, Cr3:Cb3:Cr2:Cb2:Cr1:Cb1:Cr0:Cb0 10:10:10:10:10:10:10:10 > > + */ > > +#define DRM_FORMAT_NV12_10 fourcc_code('N', 'A', '1', '2') /* 2x2 subsampled Cr:Cb plane */ > > +#define DRM_FORMAT_NV21_10 fourcc_code('N', 'A', '2', '1') /* 2x2 subsampled Cb:Cr plane */ > > +#define DRM_FORMAT_NV16_10 fourcc_code('N', 'A', '1', '6') /* 2x1 subsampled Cr:Cb plane */ > > +#define DRM_FORMAT_NV61_10 fourcc_code('N', 'A', '6', '1') /* 2x1 subsampled Cb:Cr plane */ > > +#define DRM_FORMAT_NV24_10 fourcc_code('N', 'A', '2', '4') /* non-subsampled Cr:Cb plane */ > > +#define DRM_FORMAT_NV42_10 fourcc_code('N', 'A', '4', '2') /* non-subsampled Cb:Cr plane */ > > + > > +/* > > * 2 plane YCbCr MSB aligned > > * index 0 = Y plane, [15:0] Y:x [10:6] little endian > > * index 1 = Cr:Cb plane, [31:0] Cr:x:Cb:x [10:6:10:6] little endian > >