Re: [net-next,v8,2/5] dt-bindings: net: dsa: microchip: Add KSZ8995XA

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Concern (validated as FALSE POSITIVE by series-end verification):
  the newly documented `microchip,ksz8995xa` compatible was reported to…

--

dt-bindings: net: dsa: microchip: Add KSZ8995XA

This adds a new compatible string microchip,ksz8995xa to the Microchip KSZ
switch binding, noting the part was renamed from KS8995XA and that
KSZ8995MA and KSZ8995E are different parts.

> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 8d4a3a9a33fcc..4ed13870ed3ac 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -23,6 +23,7 @@ properties:
>        - microchip,ksz8864  # 4-port version of KSZ8895 family switch
>        - microchip,ksz8873
>        - microchip,ksz8895  # 5-port version of KSZ8895 family switch
> +      - microchip,ksz8995xa

[Severity: Low]
At this commit, is there anything in tree that matches this compatible?

A device tree node using microchip,ksz8995xa passes dt_binding_check here,
but ksz_dt_ids[] in drivers/net/dsa/microchip/ksz_spi.c has no entry for
it yet, so the node would not probe.

That said, the following patch in the same series ("net: dsa: microchip:
Support Microchip KSZ8995XA / KS8995XA") adds the matching entry:

drivers/net/dsa/microchip/ksz_spi.c:ksz_dt_ids[] {
	...
	{
		.compatible = "microchip,ksz8995xa",
		.data = &ksz_switch_chips[KSZ8995XA]
	},
	...
}

along with ksz_switch_chips[KSZ8995XA] and the { "ksz8995" } spi_device_id
entry, so at the tip of the series the string does resolve to a driver.
Documenting the binding ahead of the driver is the usual ordering, so this
is only a note about the intermediate state rather than something that
breaks a previously working configuration.

>        - microchip,ksz9477
>        - microchip,ksz9897
>        - microchip,ksz9896

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831-ks8995-to-ksz8-v8-0-fd1dbb2b76e8%40kernel.org