Re: [PATCH net-next v8 4/6] selftests: drv-net: refactor so_txtime errqueue handling

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Commit message hygiene: the per-revision changelog block of
  commit "selftests: drv-net: refactor so_txtime errqueue handling"…

--

selftests: drv-net: refactor so_txtime errqueue handling

This patch splits do_recv_errqueue_timeout() in
tools/testing/selftests/drivers/net/so_txtime.c into a dispatcher
do_recv_errqueue() plus a new helper do_recv_errqueue_txtime() that keeps the
SO_EE_ORIGIN_TXTIME specific handling.  It is preparation for handling
SO_EE_ORIGIN_TIMESTAMPING messages in the following patch, with no functional
change intended.

The only comment below concerns the recorded commit message, so the diff hunks
are omitted.

> Signed-off-by: Willem de Bruijn <willemb@google.com>
>
> --
>
> Changes
>   v3 -> v4
>     - rename func to do_recv_errqueue_txtime

[Severity: Low]
This isn't a code bug, but should the per-revision changelog be separated by
a three-dash line instead of "--"?

git mailinfo only truncates the message at a line of exactly three dashes or
at an explicit scissors marker, so a "--" line is kept as ordinary body text.
The recorded commit for d88dea26ea55958d0982df4811107d0743ccf08d ends with:

    Signed-off-by: Willem de Bruijn <willemb@google.com>

    --

    Changes
      v3 -> v4
        - rename func to do_recv_errqueue_txtime

That leaves the changelog permanently in the git history, and it sits after
the Signed-off-by trailer, so the trailer block is no longer the last section
of the message.

Could this be resent with "---" before the changelog block, or with the block
dropped?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260902181747.2483351-1-willemdebruijn.kernel%40gmail.com