From: patchwork-bot+netdevbpf@kernel.org
To: Nikhil P. Rao <nikhil.rao@amd.com>
Cc: netdev@vger.kernel.org, brett.creeley@amd.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
eric.joyner@amd.com
Subject: Re: [PATCH net] ionic: use netif_txq_maybe_stop() in ionic_tx()
Date: Fri, 04 Sep 2026 23:10:08 +0000 [thread overview]
Message-ID: <178856340840.1009860.16553882310182134146.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260901055627.1373129-1-nikhil.rao@amd.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 1 Sep 2026 05:56:27 +0000 you wrote:
> Commit 061b9bedbef1 ("ionic: Rework Tx start/stop flow") replaced
> ionic_maybe_stop_tx() with netif_txq_maybe_stop() to get the memory
> barriers around the stop/start bits right, but did not cover the stop
> in ionic_tx() added by commit 138506ab249b ("ionic: Check stop no
> restart"). Convert the remaining site.
>
> netif_txq_maybe_stop() requires the ring indexes to be updated before
> it is invoked, so the post has to come first. But ring_dbell comes
> from __netdev_tx_sent_queue(), which runs after that and reads the
> stop bit, so it is not known in time to pass to ionic_txq_post(). Post
> without the doorbell and ring it separately.
>
> [...]
Here is the summary with links:
- [net] ionic: use netif_txq_maybe_stop() in ionic_tx()
https://git.kernel.org/netdev/net/c/c91b4d6e5cc3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-04 23:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 5:56 [PATCH net] ionic: use netif_txq_maybe_stop() in ionic_tx() Nikhil P. Rao
2026-09-04 23:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178856340840.1009860.16553882310182134146.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.rao@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.