Re: [PATCH net-next v5 08/12] gve: split up notify block allocation and setup paths

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Style artifact: removing the old gve_free_notify_blocks() body
  leaves two consecutive blank lines between the end of…

--

gve: split up notify block allocation and setup paths

This splits gve_alloc_notify_blocks() into separate allocation and setup
phases so that MSI-X vectors can be requested after the IRQ doorbell
offsets are known. Teardown is handled by a new
gve_teardown_notify_blocks(), tracked by the new irq_requested and
mgmt_irq_requested flags.

> diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
> index 5ad7a8f9bbddb..619ef46a7b30a 100644
> --- a/drivers/net/ethernet/google/gve/gve_main.c
> +++ b/drivers/net/ethernet/google/gve/gve_main.c

[ ... ]

> @@ -538,61 +596,12 @@ static int gve_alloc_notify_blocks(struct gve_priv *priv)
>  			cur_cpu = cpumask_first(node_mask);
>  	}
>  	return 0;

[ ... ]

> +abort:
> +	gve_teardown_notify_blocks(priv);
>  	return err;
>  }
>  
> -static void gve_free_notify_blocks(struct gve_priv *priv)
> -{
> -	int i;
> -
> -	if (!priv->msix_vectors)
> -		return;

[ ... ]

> -	pci_disable_msix(priv->pdev);
> -	kvfree(priv->msix_vectors);
> -	priv->msix_vectors = NULL;
> -}
>  
>  static void gve_free_control_plane_resources(struct gve_priv *priv)
>  {

[Severity: Low]
This isn't a bug, but removing the old gve_free_notify_blocks() body leaves
two consecutive blank lines between the closing brace of
gve_setup_notify_blocks() and gve_free_control_plane_resources():

	abort:
		gve_teardown_notify_blocks(priv);
		return err;
	}

	static void gve_free_control_plane_resources(struct gve_priv *priv)

checkpatch reports "CHECK: Please don't use multiple blank lines" here.
Worth dropping one of them so the submission is checkpatch clean?

Note that the next patch in the series, "gve: introduce new methods to handle
IRQ doorbells", happens to remove the extra blank line, so the artifact does
not survive to the end of the series.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260903215606.31633-1-hramamurthy%40google.com