Re: [PATCH net-next 1/3] netlink: specs: fou: add af to the shared attribute list

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Missing `Fixes:` tag on a user-visible ynl/uAPI-codegen fix.

--

netlink: specs: fou: add af to the shared attribute list

The fou spec's &all_attrs anchor, used by the add do request and the get
do/dump reply, did not list the af attribute.  This patch adds it, so ynl
generated clients gain a setter for it and the get reply struct gains a
member.  Only user space codegen and the rendered docs change.

> diff --git a/Documentation/netlink/specs/fou.yaml b/Documentation/netlink/specs/fou.yaml
> index 331f1b342b3ad..32d34be1dc63a 100644
> --- a/Documentation/netlink/specs/fou.yaml
> +++ b/Documentation/netlink/specs/fou.yaml
> @@ -90,6 +90,7 @@ operations:
>          request: &all_attrs
>            attributes:
>              - port
> +            - af

[Severity: Low]
Would a Fixes: tag be appropriate here?

git blame shows the &all_attrs anchor lines, including the local-v6 /
peer-v6 entries, come from 4eb77b4ecd3c ("netlink: add a proto
specification for FOU"); the only later touch, 791a9ed0a40d ("netlink:
specs: fou: replace underscores with dashes in names"), just renamed
names.

The effect described in the commit message is user visible: since
parse_nl_config() in net/ipv4/fou_core.c is the only place the family is
chosen and only switches away from AF_INET when FOU_ATTR_AF is present, a
generated client had no way to create an IPv6 FOU port, and fou_fill_info()
puts FOU_ATTR_AF unconditionally so the reply struct was missing a member
for an attribute present in every reply.

The same file has precedent for tagging a spec-only change:
791a9ed0a40d carried Fixes: 4eb77b4ecd3c ("netlink: add a proto
specification for FOU").

Without the tag, would a stable backporter have to bisect the spec history
to find where the omission came from?

>              - ipproto
>              - type
>              - remcsum-nopartial

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260904191412.3872344-1-kuba%40kernel.org