Re: [PATCH net-next v9 1/4] dt-bindings: net: dsa: microchip: Add KSZ8995XA

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Concern (verified as a FALSE POSITIVE by series validation): the
  new compatible `microchip,ksz8995xa` added to…

--

dt-bindings: net: dsa: microchip: Add KSZ8995XA

This adds a new compatible string microchip,ksz8995xa to the Microchip
KSZ switch family binding, described as having the same properties as
the older KS8995XA part. No other schema constraints are changed.

> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 8d4a3a9a33fcc..4ed13870ed3ac 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -23,6 +23,7 @@ properties:
>        - microchip,ksz8864  # 4-port version of KSZ8895 family switch
>        - microchip,ksz8873
>        - microchip,ksz8895  # 5-port version of KSZ8895 family switch
> +      - microchip,ksz8995xa

[Severity: Low]
At this commit alone, is there any driver in tree that matches
microchip,ksz8995xa?  The existing part appears to be handled by the older
micrel,ks8995 binding and drivers/net/dsa/ks8995.c, so a device tree using
the new string would document a compatible that nothing binds to yet.

Checking the rest of the series, this looks already answered: the later
commit "net: dsa: microchip: Support Microchip KSZ8995XA / KS8995XA" adds

  drivers/net/dsa/microchip/ksz_spi.c:ksz_dt_ids
    { .compatible = "microchip,ksz8995xa",
      .data = &ksz_switch_chips[KSZ8995XA] },

along with ksz8995xa_regs[], ksz8995xa_dev_ops and ksz8995xa_switch_ops in
ksz_common.c, and "net: dsa: ks8995: Delete surplus driver" removes the
legacy driver and its micrel,* match table.  Documenting the binding one
patch ahead of the driver match entry is normal series ordering, so no
functional change results.

For completeness, the two if-then blocks in microchip,ksz.yaml (the
ksz8863/ksz8873 three-port block and the ksz8463 pinctrl/straps block) do
not appear to apply to this five-port part, so is it correct that neither
needs the new string added?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260906-ks8995-to-ksz8-v9-0-8d8815a91bd8%40kernel.org