All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: linusw@kernel.org
Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
	andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	marex@denx.de, horms@kernel.org, linux@armlinux.org.uk,
	nb@tipi-net.de, netdev@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v13 1/4] dt-bindings: net: dsa: microchip: Add KSZ8995XA
Date: Mon, 14 Sep 2026 20:46:56 +0000	[thread overview]
Message-ID: <178941881689.22033.5621078266167272370@kernel.org> (raw)
In-Reply-To: <20260913-ks8995-to-ksz8-v13-1-327b16d309eb@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Concern (validated as a FALSE POSITIVE, retained only because
  requires_validation=true): the concern claims that adding…

--

dt-bindings: net: dsa: microchip: Add KSZ8995XA

This adds a microchip,ksz8995xa compatible string to the Microchip KSZ
DSA switch binding. The commit notes the part was renamed from KS8995XA
and shares its properties, while KSZ8995MA and KSZ8995E are different
devices.

No Link: tags are present in the commit header.

> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 8d4a3a9a33fcc..4ed13870ed3ac 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -23,6 +23,7 @@ properties:
>        - microchip,ksz8864  # 4-port version of KSZ8895 family switch
>        - microchip,ksz8873
>        - microchip,ksz8895  # 5-port version of KSZ8895 family switch
> +      - microchip,ksz8995xa
>        - microchip,ksz9477
>        - microchip,ksz9897
>        - microchip,ksz9896

No regressions to report on this patch.

For the record, one point was checked and found not to be an issue: whether
the new compatible belongs in this file rather than in
Documentation/devicetree/bindings/net/dsa/micrel,ks8995.yaml, and whether any
driver matches it. Later patches in the same series add
{ .compatible = "microchip,ksz8995xa", .data = &ksz_switch_chips[KSZ8995XA] }
to ksz_dt_ids and { "ksz8995xa" } to ksz_spi_ids in
drivers/net/dsa/microchip/ksz_spi.c, along with the KSZ8995XA chip
description in ksz_common.c, so microchip,ksz.yaml is the matching binding
file. The only compatible-conditional blocks in this schema cover
ksz8863/ksz8873 and ksz8463, neither of which applies to this part, so no
if-then block needed updating.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260913-ks8995-to-ksz8-v13-0-327b16d309eb%40kernel.org

  reply	other threads:[~2026-09-14 20:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 19:56 [PATCH net-next v13 0/4] net: dsa: microchip: Add support for KSZ8995XA/KS8995XA Linus Walleij
2026-09-13 19:56 ` [PATCH net-next v13 1/4] dt-bindings: net: dsa: microchip: Add KSZ8995XA Linus Walleij
2026-09-14 20:46   ` netdev-bot+sashiko [this message]
2026-09-13 19:56 ` [PATCH net-next v13 2/4] net: dsa: tag_ks8995: Add the KS8995 tag handling Linus Walleij
2026-09-14 19:57   ` sashiko-bot
2026-09-14 20:41     ` Linus Walleij
2026-09-14 20:46   ` netdev-bot+sashiko
2026-09-13 19:56 ` [PATCH net-next v13 3/4] net: dsa: microchip: Support Microchip KSZ8995XA / KS8995XA Linus Walleij
2026-09-13 20:10   ` Nicolai Buchwitz
2026-09-14 19:57   ` sashiko-bot
2026-09-14 20:46   ` netdev-bot+sashiko
2026-09-13 19:56 ` [PATCH net-next v13 4/4] net: dsa: ks8995: Delete surplus driver Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178941881689.22033.5621078266167272370@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marex@denx.de \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.