From: Vinod Koul <vkoul@kernel.org>
To: frank.li@nxp.com, Slavin Liu <bolin.liu@seu.edu.cn>
Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] dmaengine: fsl-edma: check channel acquisition before use
Date: Tue, 15 Sep 2026 23:06:32 +0530 [thread overview]
Message-ID: <178949379263.248239.2249782721178774310.b4-ty@kernel.org> (raw)
In-Reply-To: <20260911060902.94153-1-bolin.liu@seu.edu.cn>
On Fri, 11 Sep 2026 14:09:02 +0800, Slavin Liu wrote:
> dma_get_slave_channel() can return NULL when acquiring a channel fails,
> for example if fsl_edma_alloc_chan_resources() cannot request an IRQ.
> fsl_edma3_xlate() dereferences that return value to update privatecnt.
>
> Acquire and check the channel before publishing its source ID and
> request parameters. A NULL-only check after the existing source-ID
> assignment would leave the failed request marked as in use, causing
> fsl_edma_srcid_in_use() to reject a subsequent request for that source.
> The channel resource-allocation callback does not consume these request
> parameters, so set them only after acquisition succeeds. The existing
> scoped mutex release and successful-channel return are preserved.
>
> [...]
Applied, thanks!
[1/1] dmaengine: fsl-edma: check channel acquisition before use
commit: bfd958664fccd794377a8adb74b492498c824643
Best regards,
--
~Vinod
prev parent reply other threads:[~2026-09-15 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 6:09 [PATCH RFC] dmaengine: fsl-edma: check channel acquisition before use Slavin Liu
2026-09-11 6:26 ` sashiko-bot
2026-09-11 14:56 ` Frank Li
2026-09-14 15:58 ` Frank Li
2026-09-15 17:36 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178949379263.248239.2249782721178774310.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=bolin.liu@seu.edu.cn \
--cc=dmaengine@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.