From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 0/3] *** Upgrade NIC share codes ***
Date: Mon, 19 May 2014 11:18:18 +0200 [thread overview]
Message-ID: <1789529.RGC5GB4S3q@xps13> (raw)
In-Reply-To: <1400120294-15871-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Hi Jijiang,
I feel there is a lot of important changes in these patches but I cannot
easily read them. Splitting in many small patches with nice commit logs would
help a lot.
Please refer to http://dpdk.org/dev#send in order to understand what must be a
good patch.
At least, you should make patches for minor changes (whitespace/typo/case),
few patches for new features (e.g. M88E1512, SFP+ laser) and few patches for
bug fixes (e.g. pll_workaround_i210, locks, fc-autoneg, vf link).
Especially, an explanation is needed for locking changes as there were some
work on it in these commits:
http://dpdk.org/browse/dpdk/commit/?id=4c9d8ed203c1170e4cc11
http://dpdk.org/browse/dpdk/commit/?id=f283b30509d2db745e746
"git add -p" could help you to split the changes into several commits.
You can check how minor changes in base driver were handled previously.
Examples from version 1.5.1:
http://dpdk.org/browse/dpdk/commit/?id=1558bea6e3723d9c1
http://dpdk.org/browse/dpdk/commit/?id=2fd4855f306e9df38
http://dpdk.org/browse/dpdk/commit/?id=5037620be576a3c20
http://dpdk.org/browse/dpdk/commit/?id=1d2d65121bd10ba95
Thanks
--
Thomas
next prev parent reply other threads:[~2014-05-19 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 2:18 [PATCH 0/3] *** Upgrade NIC share codes *** Jijiang Liu
[not found] ` <1400120294-15871-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-15 2:18 ` [PATCH 1/3] Upgrade share codes:upgrade NIC shared code in ixgbe & e1000 directories Jijiang Liu
2014-05-15 2:18 ` [PATCH 2/3] Upgrade share codes:fix an issue of hash calculation of flow director introduced by upgrading NIC share codes Jijiang Liu
2014-05-15 2:18 ` [PATCH 3/3] Upgrade share codes:change Copyright date of e1000_osdep.c and e1000_osdep.h files Jijiang Liu
2014-05-19 9:18 ` Thomas Monjalon [this message]
2014-05-27 1:51 ` [PATCH 0/3] *** Upgrade NIC share codes *** Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01C79D65-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 21:51 ` Thomas Monjalon
2014-06-04 14:53 ` Cao, Waterman
2014-06-05 5:20 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1789529.RGC5GB4S3q@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.